Repository navigation
fix(status): classify re-created cross-view files as Added, not invisible - #103
Closed
vinceblock99 wants to merge 2 commits into
Closed
vinceblock99 wants to merge 2 commits into
vinceblock99 wants to merge 2 commits into
Conversation
…ible The status tree scan skipped any file whose creating change is not visible on the current view. Correct when the file is absent from the working copy (another view's file must not show up here, e.g. as Deleted) — but when the working copy HAS the file (re-created on this view after a switch), skipping it opened a permanent gap: 'add' refuses it because the global TREE already tracks it, while status called it untracked-and-clean, so 'record' could never see it — every agent turn that re-created such a file became a false EmptyTurn, forever. Now a cross-view tree entry that exists on disk falls through with no visible graph content and classifies as Added, exactly what the scan's own comment prescribes for tree entries without a visible position. The extra disk stat runs only for cross-view entries, which are rare. Found doing real multi-session work in one repo (a file created by an earlier session on another view, re-created by a later session). Regression test drives two real orchestrator sessions end-to-end.
Contributor
|
i think this is a duplicate of the PR I opened yesterday. |
Contributor
Author
Thanks! closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a status bug with files that appear on multiple views.
If a file was first recorded on one view, then later re-created on another view,
atomic statuscould skip it. That maderecordthink there was nothing to save, even though the file existed on disk.This PR treats that file as
Addedon the current view when it exists in the working copy.Why
Managed runs and sandboxed workflows often work on different views. If two runs touch the same file path, the later run must still be recordable.
Without this fix, a real agent turn could end as a false
EmptyTurnand lose the change from the current view.Verified
Added a regression test with two orchestrator sessions on different views. The second session re-creates the same file path and now records it correctly.