Skip to content

feat(intent): --reason for icebox + unmet/met acceptance-criterion status - #116

Merged
geekgonecrazy merged 3 commits into
devfrom
feat/intent-reject-reason
Jul 17, 2026
Merged

geekgonecrazy merged 3 commits into
devfrom
feat/intent-reject-reason

Conversation

@graywolf336

@graywolf336 graywolf336 commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • atomic intent update gains a --reason flag; when set (typically with --status icebox) it persists icebox_reason + an iceboxed_at (RFC 3339) timestamp to the intent frontmatter (additive; source body untouched).
  • Make unmet/met the official acceptance-criterion status vocabulary (vocab::AC_STATUS); the legacy open is still accepted by is_known_ac_status so pre-existing intents keep conforming. intent new now scaffolds criteria/tasks with status=unmet.
  • Add icebox to INTENT_STATUS — a terminal "reviewed but not built" state.

Notes

This touches the shared canonical vocab, so the full test suite should run in CI.

- intent update: new --reason flag; when set, persists rejection_reason and
  stamps rejected_at (RFC 3339) onto the intent frontmatter (additive).
- IntentUpdateOptions: carry the reason through the repository write path.
- vocab: add 'rejected' to INTENT_STATUS so a reviewed-and-declined intent is a
  valid canonical/terminal state (gate, validate, and attest pre-check accept it).
- vault intent update: pass reason: None on the legacy verb for compatibility.
@graywolf336
graywolf336 force-pushed the feat/intent-reject-reason branch from 1cd68f8 to c59d80e Compare July 16, 2026 04:17
@graywolf336
graywolf336 changed the base branch from release to dev July 16, 2026 04:17
Rename the acceptance-criterion status vocabulary from open/met to unmet/met so
the value reads unambiguously against a met criterion. is_known_ac_status still
accepts the legacy 'open' (== unmet) so pre-existing intents keep conforming, and
the intent-new scaffold now seeds status=unmet for criteria and tasks.
@graywolf336
graywolf336 force-pushed the feat/intent-reject-reason branch from c59d80e to 8d1000c Compare July 16, 2026 04:21
Softer terminal state for a reviewed-but-not-built intent. INTENT_STATUS
rejected→icebox; the --reason handler now persists icebox_reason + iceboxed_at
(was rejection_reason/rejected_at).
@graywolf336 graywolf336 changed the title feat(intent): --reason for rejection + unmet/met acceptance-criterion status feat(intent): --reason for icebox + unmet/met acceptance-criterion status Jul 17, 2026
@geekgonecrazy
geekgonecrazy marked this pull request as ready for review July 17, 2026 18:21
@geekgonecrazy
geekgonecrazy merged commit 90bad47 into dev Jul 17, 2026
8 checks passed
@geekgonecrazy
geekgonecrazy deleted the feat/intent-reject-reason branch July 17, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants