Repository navigation
fix(teams): accept everyone workspace grants - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrantSubjectType::Everyoneso Atomic can deserialize public/wildcard grants returned by Storageeveryonevalue in JSON and CLI outputEveryonesubject in add/revoke helpers, because Storage mutation endpoints accept only concrete user or team UUIDsWhy
atomic workspace grant list oss --org atomic --format jsonfailed in v0.13.0 with:Storage represents a public workspace with an
everyone/readReBAC tuple whosesubject_idis null. The CLI model did not include that valid server-side subject type.Test coverage
cargo fmt --all -- --checkcargo test -p atomic-teams --quiet(62 passed)cargo test -p atomic-cli --quiet(1,758 unit/integration tests passed)cargo clippy -p atomic-teams -p atomic-cli --all-targets -- -D warningseveryone/readgrant successfullyScope
This fixes grant-list response compatibility. It does not change workspace ACLs; an OSS workspace with only
everyone: readstill requires an explicit user or team write grant for push/write operations.