Skip to content

fix(teams): accept everyone workspace grants - #151

Merged
graywolf336 merged 2 commits into
devfrom
fix/workspace-grant-everyone
Aug 6, 2026
Merged

graywolf336 merged 2 commits into
devfrom
fix/workspace-grant-everyone

Conversation

@vinceblock99

Copy link
Copy Markdown
Contributor

Summary

  • add GrantSubjectType::Everyone so Atomic can deserialize public/wildcard grants returned by Storage
  • preserve the exact everyone value in JSON and CLI output
  • reject the response-only Everyone subject in add/revoke helpers, because Storage mutation endpoints accept only concrete user or team UUIDs
  • document the public grant variant and add regression coverage for the production response shape

Why

atomic workspace grant list oss --org atomic --format json failed in v0.13.0 with:

invalid response JSON: unknown variant `everyone`, expected `user` or `team`

Storage represents a public workspace with an everyone/read ReBAC tuple whose subject_id is null. The CLI model did not include that valid server-side subject type.

Test coverage

  • cargo fmt --all -- --check
  • cargo test -p atomic-teams --quiet (62 passed)
  • cargo test -p atomic-cli --quiet (1,758 unit/integration tests passed)
  • cargo clippy -p atomic-teams -p atomic-cli --all-targets -- -D warnings
  • built the patched v0.13.0 CLI and verified the production command above returns the everyone/read grant successfully

Scope

This fixes grant-list response compatibility. It does not change workspace ACLs; an OSS workspace with only everyone: read still requires an explicit user or team write grant for push/write operations.

@vinceblock99
vinceblock99 marked this pull request as ready for review August 5, 2026 21:23
@graywolf336
graywolf336 merged commit 397ace4 into dev Aug 6, 2026
8 checks passed
@graywolf336
graywolf336 deleted the fix/workspace-grant-everyone branch August 6, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants