Skip to content

fix: align release Rust toolchain with repository pin - #318

Merged
geekgonecrazy merged 1 commit into
devfrom
fix/release-rust-toolchain-20261103
Nov 3, 2026
Merged

geekgonecrazy merged 1 commit into
devfrom
fix/release-rust-toolchain-20261103

Conversation

@vinceblock99

Copy link
Copy Markdown
Contributor

Prepare Release #27 fails on four cross-compilation targets with E0463 because the release workflow installs target standard libraries for Rust 1.98.1 (dtolnay/rust-toolchain@1.98), while rust-toolchain.toml selects Rust 1.98.0 for the actual build.

Pin the release action to @1.98.0 so target installation and compilation use the same toolchain. Add a comment explaining why the action version must match the repository pin.

Affected run: https://github.com/atomicdotdev/atomic/actions/runs/41720270364

Validation:

  • Parsed the workflow YAML and checked that the action version matches rust-toolchain.toml and target installation remains configured for all seven matrix entries.
  • Verified that the upstream @1.98.0 action installs the supplied targets into Rust 1.98.0.
  • Reproduced E0463 locally with an Intel macOS compilation probe before installing the target standard library.
  • After installing the four affected targets for Rust 1.98.0, compiled both core and std probes to Rust metadata for x86_64-apple-darwin, x86_64-unknown-linux-musl, aarch64-unknown-linux-gnu, and aarch64-unknown-linux-musl, using the repository-selected toolchain.
  • git diff --check passed.

These checks validate toolchain selection and target standard-library availability. Full Atomic compilation, linking, and release packaging still require CI validation.

@geekgonecrazy
geekgonecrazy merged commit 69574fb into dev Nov 3, 2026
10 checks passed
@geekgonecrazy
geekgonecrazy deleted the fix/release-rust-toolchain-20261103 branch November 3, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants