Repository navigation
fix: align release Rust toolchain with repository pin - #318
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Release #27 fails on four cross-compilation targets with E0463 because the release workflow installs target standard libraries for Rust 1.98.1 (
dtolnay/rust-toolchain@1.98), whilerust-toolchain.tomlselects Rust 1.98.0 for the actual build.Pin the release action to
@1.98.0so target installation and compilation use the same toolchain. Add a comment explaining why the action version must match the repository pin.Affected run: https://github.com/atomicdotdev/atomic/actions/runs/41720270364
Validation:
rust-toolchain.tomland target installation remains configured for all seven matrix entries.@1.98.0action installs the supplied targets into Rust 1.98.0.coreandstdprobes to Rust metadata forx86_64-apple-darwin,x86_64-unknown-linux-musl,aarch64-unknown-linux-gnu, andaarch64-unknown-linux-musl, using the repository-selected toolchain.git diff --checkpassed.These checks validate toolchain selection and target standard-library availability. Full Atomic compilation, linking, and release packaging still require CI validation.