Repository navigation
fix: accept reviewed set-aside intents as complete review scope - #338
Merged
Merged
Conversation
vinceblock99
marked this pull request as ready for review
November 13, 2026 20:42
vinceblock99
force-pushed
the
fix/review-scope-set-aside
branch
from
November 13, 2026 20:49
98201f2 to
f4f7256
Compare
leefaus
force-pushed
the
fix/triage-review
branch
from
November 15, 2026 16:33
7733812 to
2eab9c6
Compare
The subject scope-completeness rule only recognized includesIntent, but the resolver pins icebox intents under includesSetAside. A change whose retained receipts observe an intent that was later set aside could never pass validation, even when the review intent explicitly reviews it. Accept either relation for scope completeness. Managed-change coverage still requires includesIntent, so a set-aside intent cannot stand in as implementation evidence (covered by the existing retired_intent_cannot_supply_managed_change_coverage test). Note: the shapes file participates in profile_hash, so previously signed reviews will read as stale and need a superseding signature.
vinceblock99
force-pushed
the
fix/review-scope-set-aside
branch
from
November 15, 2026 17:55
f4f7256 to
b6f14cc
Compare
vinceblock99
added a commit
that referenced
this pull request
Nov 15, 2026
* fix the review process with new ontology * fix: accept reviewed set-aside intents as complete review scope (#338) The subject scope-completeness rule only recognized includesIntent, but the resolver pins icebox intents under includesSetAside. A change whose retained receipts observe an intent that was later set aside could never pass validation, even when the review intent explicitly reviews it. Accept either relation for scope completeness. Managed-change coverage still requires includesIntent, so a set-aside intent cannot stand in as implementation evidence (covered by the existing retired_intent_cannot_supply_managed_change_coverage test). Note: the shapes file participates in profile_hash, so previously signed reviews will read as stale and need a superseding signature. --------- Co-authored-by: Vincent <vince@atomic.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #336 (
fix/triage-review).Problem
The
shape:Subjectscope-completeness rule only recognizesincludesIntent, but the resolver pinsiceboxintents underincludesSetAside. So a reviewed change whose retained receipts observe an intent that was later set aside fails validation witheven when the review intent explicitly
reviewsthat intent. There is no way to satisfy the rule from the review side.Reproduction (now the regression test
reviewed_set_aside_intent_observed_by_a_change_does_not_block): one change, one retained receipt attesting two work intents by the same author; the second intent is later set toicebox; the review intent reviews both. Before this change validation fails with the message above; after it conforms.Fix
review-1.0.0.ttl: the scope-completenessFILTER NOT EXISTSacceptsincludesIntentorincludesSetAside, and the message says so.includesIntent, so a set-aside intent cannot stand in as implementation evidence. The existingretired_intent_cannot_supply_managed_change_coveragetest still passes, and the new test also asserts that dropping the set-aside intent from the review scope is rejected.Fixture::with_second_observed_intent()(one receipt node attesting several intents in a single multi-command invocation); existingreceipt_nodecallers are unchanged.docs/retrospective-publication-review.md.Note: the shapes file participates in
profile_hash, so reviews signed before this change will read as stale and need a superseding signature. That is the documented behaviour for any shape change.Tests
cargo test -p atomic-repository --features review-shacl --lib publication_review: 40 passed (39 existing + new)cargo test -p atomic-repository --features review-shacl: 1903 passed, 0 failedcargo test --workspace: 13339 passed; the only 2 failures are the pre-existing local failpoint tests that need--features adoption-test-injection(git_shim_cb13d_test::crash_during_effect_recovers_without_partial_bytes,graph_only_export_cb9b_test::graph_only_export_matrix_from_recorded_graph), unrelated to this changecargo test -p atomic-shacl,atomic-core --test kg_ontology,atomic-repository --test it intent_graph: all green