Skip to content

Fix release preparation branch and version metadata - #10

Merged
graywolf336 merged 2 commits into
releasefrom
fix/release-helper
Nov 12, 2026
Merged

graywolf336 merged 2 commits into
releasefrom
fix/release-helper

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Changes

  • Run release preparation/finalization on release, not main; print the correct push command.
  • Synchronize package.json and both package-lock.json version fields, and include the lockfile in the release commit.
  • Reject mismatched manifest/lockfile versions before committing or tagging.
  • Accept dated and undated changelog headings.
  • Prepend release notes before existing sections without requiring a horizontal-rule separator.
  • Document the workflow and add seven isolated CLI/Git regression tests.

Verification

  • bun test scripts/: 224 passed, 0 failed.
  • node --check scripts/release-prep.mjs passed.
  • Ran actual prepare and finalize commands in a disposable release-branch repository using the project manifests and changelog. Verified the annotated tag contains synchronized version metadata and the reviewed dated release notes, with a clean working tree afterward.

No project version bump, release tag, or publication performed. This PR only repairs the helper.

@graywolf336

Copy link
Copy Markdown
Contributor Author

Fixed in 599bb1b. Git for Windows rejected the test fixture's GIT_CONFIG_GLOBAL null-device path before the release helper ran. The fixture now uses an empty regular config file outside the temporary worktree; all seven release tests remain enabled.

Verification: 224 local tests passed, and actual prepare/finalize succeeded in a disposable repository. Fresh CI passed on Windows, macOS, and Linux: https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43321317657

@graywolf336
graywolf336 merged commit 08ffad7 into release Nov 12, 2026
3 checks passed
@graywolf336
graywolf336 deleted the fix/release-helper branch November 12, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant