Skip to content

Remove bundled spellchecker; preserve optional external diagnostics - #12

Merged
graywolf336 merged 1 commit into
releasefrom
refactor/remove-bundled-spellcheck
Nov 16, 2026
Merged

graywolf336 merged 1 commit into
releasefrom
refactor/remove-bundled-spellcheck

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Change

Remove Sherpa's own spellchecker rather than packaging and maintaining cspell inside the extension. Supersedes #11, which proposed bundled spelling-runtime portability.

  • Remove cspell-lib, its unused transitive dependency tree, and the local cspell type declarations.
  • Delete the built-in diagnostic/suggestion engine, owned diagnostic collection, scheduling/lifecycle, spelling setting and toolbar toggle, and spelling-only host/webview messages.
  • Preserve generic external diagnostics and replacement quick fixes. The remaining dependency-free cspellCodeActions.ts only decodes corrections supplied by an installed Code Spell Checker extension; it is not a spelling engine.
  • Keep Code Spell Checker optional: no extension dependency, forced installation, cspell CLI, or Sherpa spelling configuration.
  • Update preview initialization and user documentation. No bundled spelling runtime/build/CI machinery from Fix packaged spelling runtime and dictionary portability #11 is introduced.

Verification

  • Typecheck passed; all 224 tests passed.
  • Universal VSIX packaging and archived nodeatomic consumer verification passed; production audit reported zero vulnerabilities.
  • Lockfile contains no cspell/@cspell packages. Actual archive has no cspell dependency, Sherpa spelling setting, or dist/spell payload.
  • Actual installed VSIX in an isolated macOS ARM64 VS Code profile with no spellchecker: opened Sherpa's custom editor, edited and saved the document, with no spelling toolbar control or spelling diagnostics.
  • Actual installed VSIX with Code Spell Checker 4.10.0: Sherpa displayed the external qwick diagnostic, offered quick, applied the correction, cleared the diagnostic and saved the corrected text to disk.
  • Final package runtime/webview files match the exercised artifact; subsequent repackaging changed only release documentation.

Base / limits

Based on freshly pulled release at 08ffad7. Refreshed the default branches of all five related release repositories; original worktrees preserved. No version bump, release publication, native-runtime changes, or Puppeteer compatibility changes.

Verified local artifact: releases/atomic-sherpa-1.0.0-no-bundled-spellcheck.vsix.

@graywolf336

Copy link
Copy Markdown
Contributor Author

CI passed on Windows, macOS, and Linux: https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43929221024

Local verification: 224 tests, typecheck, universal packaging, archived nodeatomic consumer smoke, and production audit (zero vulnerabilities). Actual macOS VS Code checks exercised the packaged editor with no spellchecker, then with Code Spell Checker 4.10.0: external diagnostic, suggested correction, application, diagnostic clearing, and save all passed.

Verified local artifact: releases/atomic-sherpa-1.0.0-no-bundled-spellcheck.vsix
SHA-256: 1e509fce54eaa646d96c87d3d0d8ecfd630b508bc416da0d834069478be00416

#11 is closed as superseded. Isolated editor fixtures and the obsolete bundled-spelling artifact were removed; original worktrees were preserved. No publication or version bump.

@graywolf336
graywolf336 merged commit 467ef11 into release Nov 16, 2026
3 checks passed
@graywolf336
graywolf336 deleted the refactor/remove-bundled-spellcheck branch November 16, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant