Skip to content

Require VS Code 1.101 for Puppeteer runtime compatibility - #13

Merged
graywolf336 merged 1 commit into
releasefrom
fix/puppeteer-vscode-runtime
Nov 16, 2026
Merged

graywolf336 merged 1 commit into
releasefrom
fix/puppeteer-vscode-runtime

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Problem

Sherpa advertised VS Code 1.97+, whose extension host uses Node 20, while Puppeteer 25 requires Node >=22.12.0. Downgrading to the newest Puppeteer 24 reintroduced nine high-severity production audit findings, including extract-zip vulnerabilities with no patched release. The approved resolution is to raise the editor minimum rather than weaken the audit or maintain dependency backports.

Changes

  • Require VS Code 1.101.0+, the earliest compatible stable release.
  • Keep Puppeteer 25 and the existing separate ESM export bundle/loader unchanged; refresh the lockfile to Puppeteer 25.17.0.
  • Document the runtime requirement and the actually exercised platform/version.
  • No extension version bump, Marketplace publication, Atomic provisioning, or browser provisioning.

Why 1.101.0

Verification

  • npm run typecheck
  • npm test: 224 passed, 0 failed.
  • npm run package:vsix and final node scripts/package-universal.mjs: universal archive and extracted nodeatomic consumer verification passed.
  • npm audit --omit=dev --audit-level=low: 0 vulnerabilities.
  • Installed the generated VSIX into an isolated, official VS Code 1.101.0 on macOS ARM64.
  • Invoked the real Export as HTML and Export as PDF commands through the editor and completed the real save pickers; both reported completion.
  • Inspected finalized HTML in Chrome: Mermaid labels, two KaTeX expressions, syntax tokens, and a decoded 180×60 embedded local SVG.
  • Parsed the generated one-page PDF using PDFKit and visually inspected its rasterized page: Mermaid, inline/block math, highlighting, and embedded image rendered correctly.
  • Disposable fixtures/probes stay outside the repository. Windows/Linux minimum-version Electron-host validation is not claimed by these local checks; cross-platform CI is tracked separately.

@graywolf336

Copy link
Copy Markdown
Contributor Author

Final local verification artifact: releases/atomic-sherpa-1.0.0-vscode-1.101.vsix

SHA-256: 4402760469ee761dbf25976effbcf90760c7150d570eec972639ef6daedc4301

After packaging the updated README/changelog, all 100 archived runtime/webview files were byte-for-byte identical to the installed VSIX payload exercised through the real HTML/PDF export commands in VS Code 1.101.0 / Electron 35.5.1 / Node 22.15.1 on macOS ARM64. Final archive verification passed. Disposable editor downloads, profiles, runtime probe, export fixtures, and PDF inspection script were removed; the verified VSIX is retained locally. No version bump or publication.

@graywolf336

Copy link
Copy Markdown
Contributor Author

Cross-platform CI passed on Windows, macOS, and Linux: https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43965877543 . Local verification also passed: 224 tests, typecheck, universal VSIX/extracted-consumer checks, and production audit (0 vulnerabilities). Actual VS Code 1.101.0 HTML/PDF export commands were exercised on macOS ARM64; Windows/Linux minimum-version Electron-host validation remains unverified. No version bump or publication.

@graywolf336
graywolf336 merged commit 4df1fb3 into release Nov 16, 2026
3 checks passed
@graywolf336
graywolf336 deleted the fix/puppeteer-vscode-runtime branch November 16, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant