Repository navigation
Fix missing Atomic installation guidance in fresh workspaces - #16
Merged
Merged
Conversation
Contributor
Author
|
CI passed on Windows, macOS, and Linux, including the new isolated fresh-workspace discovery regression: https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43993327960 . Local verification: 226 tests, typecheck, universal packaging/extracted-consumer checks, view-host smoke, and production audit (0 vulnerabilities). The installed VSIX showed the installation warning and opened the official guide in a fresh Git-only project with Atomic unavailable. Retained the exact tested artifact at releases/atomic-sherpa-0.0.1-fresh-workspace.vsix; SHA-256 13281f50f870c7e6e348eb658a18f2d88e28722c9ab824822c9e382f6f17cd4b. Disposable editor/probe/fixture and isolated implementation worktrees removed. Published v0.0.1 assets remain unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published v0.0.1 checks Atomic availability only after finding a
.atomicdirectory. Fresh/Git-only workspaces therefore show “Open a local Atomic repository” instead of installation help.Change
resolveRuntime()via its public entry point; upstream API export: Expose read-only runtime discovery for consumers nodeatomic#5.Verification
ATOMIC_RUNTIME_NOT_FOUND, trusted workspace, and version 0.0.1.Tested local artifact
releases/atomic-sherpa-0.0.1-fresh-workspace.vsixSHA-256:
13281f50f870c7e6e348eb658a18f2d88e28722c9ab824822c9e382f6f17cd4bDisposable editor profile, test installation, host probe, and Git fixture removed. No version bump, GitHub release replacement, or Marketplace publication.