Skip to content

Fix missing Atomic installation guidance in fresh workspaces - #16

Merged
graywolf336 merged 1 commit into
releasefrom
fix/atomic-install-detection
Nov 17, 2026
Merged

graywolf336 merged 1 commit into
releasefrom
fix/atomic-install-detection

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Problem

The published v0.0.1 checks Atomic availability only after finding a .atomic directory. Fresh/Git-only workspaces therefore show “Open a local Atomic repository” instead of installation help.

Change

  • Check installation discovery independently in trusted local workspaces without Atomic repository markers.
  • Reuse nodeatomic's existing metadata-only resolveRuntime() via its public entry point; upstream API export: Expose read-only runtime discovery for consumers nodeatomic#5.
  • Refresh the vendored consumer entry points, upstream README, and exact source provenance. Protobuf codecs, fingerprint, and native contract are unchanged.
  • No native loading or CLI execution for the new preflight; no downloads, installation, or repairs.
  • Keep full native validation when opening Atomic repositories. Preserve untrusted/virtual/empty-workspace gating and clear stale warning state.
  • Add an isolated real-filesystem discovery regression and document the behavior.

Verification

  • Regression fails before the fix: Git-only workspace gets no installation-guide action; passes after.
  • 226 tests passed; typecheck, universal VSIX/extracted-consumer verification, existing view-host smoke, and production audit passed (0 vulnerabilities).
  • Installed the exact VSIX in an isolated actual VS Code 1.145.3 profile on macOS ARM64 with a fresh Git repository and no discoverable Atomic. Host probe confirmed ATOMIC_RUNTIME_NOT_FOUND, trusted workspace, and version 0.0.1.
  • Actual SCM panel shows “Install Atomic to enable version control”; clicking it opens the script-free guide with the official documentation link. Workspace remained Git-only.
  • Existing Atomic paths retain full runtime validation; metadata-only healthy/missing/retry, trust, virtual, and empty cases covered by regression.
  • Upstream consumer build, 27 runtime/build tests, and 25 matching-contract native/public-loading tests passed using the existing Atomic 0.22.1 archive whose full descriptor equals the pinned v0.22.0 fingerprint.

Tested local artifact

releases/atomic-sherpa-0.0.1-fresh-workspace.vsix
SHA-256: 13281f50f870c7e6e348eb658a18f2d88e28722c9ab824822c9e382f6f17cd4b

Disposable editor profile, test installation, host probe, and Git fixture removed. No version bump, GitHub release replacement, or Marketplace publication.

@graywolf336

Copy link
Copy Markdown
Contributor Author

CI passed on Windows, macOS, and Linux, including the new isolated fresh-workspace discovery regression: https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43993327960 . Local verification: 226 tests, typecheck, universal packaging/extracted-consumer checks, view-host smoke, and production audit (0 vulnerabilities). The installed VSIX showed the installation warning and opened the official guide in a fresh Git-only project with Atomic unavailable. Retained the exact tested artifact at releases/atomic-sherpa-0.0.1-fresh-workspace.vsix; SHA-256 13281f50f870c7e6e348eb658a18f2d88e28722c9ab824822c9e382f6f17cd4b. Disposable editor/probe/fixture and isolated implementation worktrees removed. Published v0.0.1 assets remain unchanged.

@graywolf336
graywolf336 merged commit 61ccec4 into release Nov 17, 2026
3 checks passed
@graywolf336
graywolf336 deleted the fix/atomic-install-detection branch November 17, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant