Skip to content

Fix native operation safety guards and conflict scoping - #8

Merged
graywolf336 merged 3 commits into
feat/native-nodeatomic-cutoverfrom
fix/native-operation-safety
Nov 12, 2026
Merged

graywolf336 merged 3 commits into
feat/native-nodeatomic-cutoverfrom
fix/native-operation-safety

Conversation

@graywolf336

Copy link
Copy Markdown
Contributor

Stacked on #7.

  • Resolve filesystem aliases in unsaved-document guards for native mutations.
  • Prevent unrelated working-copy conflicts from failing inactive-view insertion.
  • Add regression coverage and update documentation.

Verified locally on macOS ARM64: typecheck, 217 tests, view/diff host smokes, and installed VSIX workflows in real VS Code against the matching native Atomic runtime.

@graywolf336
graywolf336 added this pull request to stack #9 November 10, 2026 19:31
@graywolf336

Copy link
Copy Markdown
Contributor Author

Refreshed the vendored nodeatomic package from the published Atomic v0.22.0 library (producer 61d8040ed25508ca00b778ae01d7c32499f1cab3), regenerating codecs/types and the strict descriptor fingerprint rather than changing the hash alone.

Verification: 52 upstream nodeatomic tests, 217 Sherpa tests, typecheck, native integration, universal VSIX verification with real native dispatch, and production audit (0 vulnerabilities) passed. Actual macOS VS Code verification covered Add/Record, native recorded-file diffs, source save, ticket title edit/save preservation, view creation/switching/deletion, and the unsaved-buffer guard. The same VSIX also exercised the actual Homebrew-installed v0.22.0_1 native runtime.

Linux/Windows Electron-host validation and VS Code 1.97 validation are not established by these local checks. Marketplace upload is blocked by absent atomicdotdev publisher authentication.

@graywolf336
graywolf336 merged commit e6a5530 into release Nov 12, 2026
3 checks passed
@graywolf336

Copy link
Copy Markdown
Contributor Author

Post-merge release verification: CI is green on macOS, Linux, and Windows at release commit e6a5530 (https://github.com/atomicdotdev/sherpa-vscode/actions/runs/43293487629). A fresh build from that exact commit passed archived-consumer native dispatch and full native integration against published Atomic v0.22.0.

Actual VS Code staging sync also passed using an isolated clone of the previously authorized demos/hello-world-14 project. The released CLI downloaded and applied 3 changes. The installed extension performed authenticated no-op Push (0 changes stored, 0 views declared) and Pull (0 downloaded, 0 applied), preserving every source/ignore byte and a clean working copy. No remote test changes were created.

@graywolf336

Copy link
Copy Markdown
Contributor Author

Final local release artifact: releases/atomic-sherpa-1.0.0.vsix, built from merged release e6a5530. SHA-256: 0174ffbb9d7b6802a15a571c67ce903df63a42d93a0148d3be218aa2450199d8.

Fresh installation of this exact archive in actual macOS VS Code successfully performed native Add/Record against Atomic v0.22.0 and preserved the saved intent source. Marketplace upload remains pending publisher authentication; no upload was attempted.

@graywolf336
graywolf336 deleted the fix/native-operation-safety branch November 12, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant