Skip to content

fix(ci): refresh bundled npm and extend content validation time - #280

Merged
zoeyrose merged 1 commit into
mainfrom
fix/content-bundled-parser-timeout
Nov 2, 2026
Merged

zoeyrose merged 1 commit into
mainfrom
fix/content-bundled-parser-timeout

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Nov 1, 2026

Copy link
Copy Markdown
Member

Summary

Update the compatible npm 11 bundle to remove the remaining bundled
postcss-selector-parser finding, and give the full content validation job
enough time to finish checkout, validation, and cleanup.

Implementation / behavior

  • Refresh npm 11.21.0 to 11.21.1 through the existing semantic-release
    dependency ranges. The lock retains all 454 entries; only 11 existing entries
    inside npm's subtree change. The bundled parser advances from 7.1.4 to 7.1.6.
  • Raise the content job timeout from 10 to 20 minutes while preserving every
    validation step. The merged-main run completed its validation and clean-source
    steps but received the explicit ten-minute timeout annotation during finalization.
  • Document the remaining bundled dependency findings. Keep the two previously
    fixed non-bundled Undici copies and the Git 2.56 history fix unchanged.

Validation

Using the pinned Linux build image with Node 24.18.1, npm 11.16.0, Git 2.56.0,
and local Python 3.14.4 (the required remote workflow checks Python 3.13):

  • npm ci --ignore-scripts --no-audit --no-fund passed without changing the lock.
  • Verified all 453 installed dependency versions against the lockfile.
  • Both release-policy and release-safety test scripts passed.
  • actionlint .github/workflows/check.yml passed.
  • python3 tools/validate.py passed: 187 tests, all corpus/catalog/schema and
    provenance checks, and isolated runtime collection.
  • git diff --check passed.

Limitations / follow-up

This is a partial dependency remediation. npm 11.21.1 still bundles Undici 6.29.0
and minimatch 10.2.5, which remain affected by
Undici advisories and
the minimatch advisory.
The inspected npm 12.2.1 bundle has the same affected versions and falls outside
the current parent range. No npm major override, minimatch override, vendored
bundle patch, authored-content change, or validator weakening is included.

Track a compatible upstream npm bundle containing Undici 6.29.1 or later and
minimatch 11.0.1 or later. Remaining risk is not accepted or hidden by this change.

@zoeyrose

zoeyrose commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Self-review

Fresh-context independent review inspected the complete three-file diff from
097084b974b592d84f9adaa79e6755eedfa2c04a through
666fd22c0c9bae816732de88391ab629e6661bcb, along with the release/validation
workflows, affected configuration, tests, provenance, advisory evidence and
the original ten-minute timeout annotation. No actionable P0–P3 findings were
identified, so there are no finding dispositions or fix commits to report.

The reviewer independently recomputed the 454-entry lock comparison: exactly
11 existing entries change inside npm's subtree, with no additions, removals
or changes outside that subtree. All 143 bundled package manifests match the
lock after the update. The npm tarball integrity and all 453 installed package
versions were verified. The existing non-bundled Undici fixes and M1 history
repair remain unchanged. The longer timeout preserves every validation step.

Local validation passed in the pinned credential-free 2 CPU/4 GiB build worker:
Node 24.18.1, npm 11.16.0, Git 2.56.0 and Python 3.14.4; npm ci with unchanged
lock; release-policy and release-safety checks; actionlint; the aggregate
validator with 187 tests, all corpus/provenance gates and runtime collection;
and git diff --check. Required current-head CI must separately pass with its
configured Python 3.13 before readiness.

This review covers a partial remediation only. Bundled Undici 6.29.0 and
minimatch 10.2.5 remain affected by their documented advisories. This receipt
does not accept those residual risks or claim that a compatible fixed parent
release exists. No npm major override, vendored patch, deployment or merge is
part of this change.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

@zoeyrose
zoeyrose marked this pull request as ready for review November 1, 2026 04:26
@zoeyrose zoeyrose self-assigned this Nov 1, 2026
@zoeyrose
zoeyrose requested a review from a team November 1, 2026 04:26
@zoeyrose
zoeyrose merged commit d96a07b into main Nov 2, 2026
9 checks passed
@zoeyrose
zoeyrose deleted the fix/content-bundled-parser-timeout branch November 2, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant