Skip to content

Held review: no defaults pin; deterministic Agent Run door order in the browser verifier #277

Closed

Description

@atyrode

Problem

Review of #276 at b71c261605 found minor follow-ups:

  • A held review can be dropped the moment it is made. heldCurrent pins review.native.defaultsRevision to the panel's last read of OMP's defaults. That read is event-backed and can be older than the press's own fresh readDefaults, so a press whose review both differs from what the panel showed and read newer defaults ends on Launch with nothing said. The owner already refuses a moved defaults revision when the held review is launched (reviewedComposition).
  • The browser verifier's Agent Run door order is not deterministic. The press no longer waits for Code's Agents read, so a press before listAgentsV2 answers takes the reviewed session; and an exact door order cannot absorb a busy registerAgentV2 that patient retries.
  • Two weak verifier checks. The narrowed-check stop is checked for "no review" only at the moment the stop renders, and the held-review case does not assert that the difference it shows is the pool the added GPT account joined.

Acceptance

  • A held review is not dropped by a moved OMP defaults revision; launching it still refuses one (unchanged).
  • The verifier waits for the Agents read before the Agent Run press, treats adjacent repeats of the profile-validating doors as one, re-checks "no review" after the narrowed stop settles, and asserts "GPT accounts join the pool" in the held case.
  • scripts/gate.sh passes.

Activity

  1. added
    bugSomething isn't working
    agent-readyScoped, prioritized and settled within authorized work
    area:pluginsPlugin actions, workflows and React surfaces
    p2Accepted improvement or design work
    on Oct 13, 2026
  2. atyrode commented on Oct 13, 2026

    @atyrode
    OwnerAuthor

    Claimed: branch fix/held-review-followup off 1233e9899f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyScoped, prioritized and settled within authorized workarea:pluginsPlugin actions, workflows and React surfacesbugSomething isn't workingp2Accepted improvement or design work

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions