Skip to content

Wording: say profile, not team, in the unanswered-models stop and the Models readouts - #272

Merged
atyrode merged 1 commit into
mainfrom
fix/profile-not-team
Oct 12, 2026
Merged

atyrode merged 1 commit into
mainfrom
fix/profile-not-team

Conversation

@atyrode

@atyrode atyrode commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Problem

The panel calls the saved model choices a profile everywhere it names them ("Recall profile", "Resume … with the current profile", "The workspace profile needs a fresh read"). Three user-facing strings still said team:

Change

  • plugins/code/workflow.ts: the stop now reads "Models the list in use or this profile needs gave no clear answer, so the list and profile stayed as they were. Verify again later, or choose a profile or accounts without them."
  • plugins/code/generator/models-sheet.tsx: "…resets the profile to the staged list's default" and "the profile is the new list's default now". Both name the list they mean, since each sentence mentions two lists.
  • plugins/scripts/verify-browser.ts: the two expectations quoting those readouts; the second now uses JSON.stringify because the text contains an apostrophe.
  • docs/configuration.md: the two sentences describing those readouts.

Identifiers, storage keys and developer prose that use "team" internally are unchanged. Behavior is unchanged.

Dependencies

  • None

Evidence

  • Local scripts/gate.sh on head 463abd2c32da3ba015bc6d7f6db0e900c785995a: exit 0; 433 unit tests pass, 0 fail; the real-browser verifier PASS (413s), including both updated Models readouts; both native proofs ok.
  • Independent review of the diff passed on this head (wording, referents, the verifier expectations character for character, and no remaining user-visible "team" under plugins/code/).

Acceptance

  • No user-visible string in plugins/code/ says "team"; the three readouts above say "profile" and name the list they mean.
  • The real-browser verifier passes with the updated Models readouts.

@atyrode
atyrode marked this pull request as ready for review October 12, 2026 16:36
@atyrode

atyrode commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Verdict: pass

Head: 463abd2c32da3ba015bc6d7f6db0e900c785995a

  • Diff: four files, eight lines; user-facing wording only, no behavior change. An independent review of an earlier head found two ambiguous "that list" referents; both now name their list ("the staged list's default", "the new list's default"), and the re-review of this head passed with no findings.
  • No user-visible "team" remains under plugins/code/; remaining uses are identifiers, storage keys, comments, assertion labels and developer prose.
  • Verifier expectations (verify-browser.ts:2796,2824) match the strings models-sheet.tsx:113-115,160 produce, character for character; the apostrophe case is serialized with JSON.stringify.
  • Local gate on this head: exit 0, 433 pass / 0 fail, browser verifier PASS (413s), both native proofs ok.
  • Acceptance: both criteria met by the evidence above; CI on this head is required before merge.

No blocking findings.

@atyrode
atyrode merged commit 9a8eed9 into main Oct 12, 2026
4 checks passed
@atyrode
atyrode deleted the fix/profile-not-team branch October 12, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant