Repository navigation
Held review: no OMP defaults pin; deterministic Agent Run door order in the browser verifier - #278
Merged
Merged
Conversation
…in the browser verifier A held review no longer pins the panel's own read of OMP's defaults, which can be older than the press's; launching it still refuses moved defaults. The browser verifier waits for Code's Agents read before the Agent Run press, treats a retried profile-validating door as one step, re-checks that the narrowed stop reviews nothing once it settles, asserts the held stop names the pool the added account joined, and chooses a machine only after the panel has picked one.
Owner
Author
|
Independent review at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-ups from the last review round of #276:
readDefaults; a press whose review both differed and read newer defaults ended on Launch with nothing said.registerAgentV2; two checks were weaker than their descriptions.chooseMachinepressed the picker while it still read "no machine", whose word changes width once the panel picks a machine.Change
heldCurrentno longer pins the OMP defaults revision; launching a held review still refuses moved defaults (reviewedComposition), and the hold is then dropped. Docs updated.core.access.listAgentsV2answer (with no Agents or terminal read in flight) before the Agent Run press; collapses adjacent repeats of the three profile-validating doors when comparing the door order; re-checks that the narrowed check stop reviews nothing after the launch settles; asserts the held stop names "GPT accounts join the pool";chooseMachinewaits until the panel has picked a machine before pressing the picker.Evidence
scripts/gate.shat2094807413: exit 0 (tsc, 452 unit tests, pack, consumer, hardened and packaged verification, browserPASS (483s), native).2094807413: pass.Closes #277