Skip to content

Held review: no OMP defaults pin; deterministic Agent Run door order in the browser verifier - #278

Merged
atyrode merged 1 commit into
mainfrom
fix/held-review-followup
Oct 13, 2026
Merged

atyrode merged 1 commit into
mainfrom
fix/held-review-followup

Conversation

@atyrode

@atyrode atyrode commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Problem

Follow-ups from the last review round of #276:

  • A held review pinned the panel's own read of OMP's defaults, which is event-backed and can be older than the press's fresh readDefaults; a press whose review both differed and read newer defaults ended on Launch with nothing said.
  • The browser verifier's Agent Run press no longer waited for Code's Agents read, and its exact door order could not absorb a retried busy registerAgentV2; two checks were weaker than their descriptions.
  • One gate run of Launch is one press: no Review step, and a busy agent plugin no longer fails the launch #276 failed at "the machine list opens" on a freshly opened workspace: chooseMachine pressed the picker while it still read "no machine", whose word changes width once the panel picks a machine.

Change

  • heldCurrent no longer pins the OMP defaults revision; launching a held review still refuses moved defaults (reviewedComposition), and the hold is then dropped. Docs updated.
  • Verifier: waits for a successful core.access.listAgentsV2 answer (with no Agents or terminal read in flight) before the Agent Run press; collapses adjacent repeats of the three profile-validating doors when comparing the door order; re-checks that the narrowed check stop reviews nothing after the launch settles; asserts the held stop names "GPT accounts join the pool"; chooseMachine waits until the panel has picked a machine before pressing the picker.

Evidence

  • scripts/gate.sh at 2094807413: exit 0 (tsc, 452 unit tests, pack, consumer, hardened and packaged verification, browser PASS (483s), native).
  • Independent review at 2094807413: pass.

Closes #277

…in the browser verifier

A held review no longer pins the panel's own read of OMP's defaults, which can be older than the press's; launching it still refuses moved defaults. The browser verifier waits for Code's Agents read before the Agent Run press, treats a retried profile-validating door as one step, re-checks that the narrowed stop reviews nothing once it settles, asserts the held stop names the pool the added account joined, and chooses a machine only after the panel has picked one.
@atyrode atyrode added bug Something isn't working area:plugins Plugin actions, workflows and React surfaces labels Oct 13, 2026
@atyrode

atyrode commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

Independent review at 2094807413750967ebb60d1a66339b37982caa54: pass. CI at this head: agent-policy, plugins / verify and test pass. Local scripts/gate.sh at this head: exit 0.

@atyrode
atyrode merged commit 5b37142 into main Oct 13, 2026
4 checks passed
@atyrode
atyrode deleted the fix/held-review-followup branch October 13, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugins Plugin actions, workflows and React surfaces bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Held review: no defaults pin; deterministic Agent Run door order in the browser verifier

1 participant