Repository navigation
A Launch that waits on the person opens a dialog; press outcomes reach the notice stack - #281
Merged
Merged
Conversation
…h the notice stack
…hen they happen or never
…d review is asked when it happens or never
…istive activations and 44 px refused choices
Owner
Author
|
Head-specific evidence for
Not reachable in the verifier's fixture: a successful launch or resume (and their "Launched on" / "Resumed on" notices), since it never opens a terminal. |
Owner
Author
|
Independent review (head-specific): pass at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every question a Launch press waits on is now asked in a modal dialog instead of a short line beside the launch control, and how a press ended also reaches Manifold's notice stack.
Safety of the dialog
Esc, a press that starts and ends on the backdrop, and a browser-forced close take the way out, which never spends or launches. A drag from the box to the backdrop, or a press on its border, answers nothing.decisionFor,answerindecision-model.ts) and unit-tested: a check the panel runs on its own never asks; only Approve approves; every other answer to a charge cancels first; no way out launches or approves.Also
README.md: the launch row no longer lists Review, and the stale sentence saying the skill, automation and continuation additions are source-only is removed (they ship in the released bundles).Verification
scripts/gate.shpasses (see the head-specific comment).Closes #279