Repository navigation
test: cover charge door unknown decode path - #11
Conversation
augard
added
codex
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
|
@codex please review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2795e42c4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| of: "\"ChargingDoor\": {\n \"State\": 2,", | ||
| with: "\"ChargingDoor\": {\n \"State\": 0," |
There was a problem hiding this comment.
The multiline string in createVehicleStateJSON strips the closing delimiter's 8-space indentation, so the generated "State" line has 12 leading spaces, while this search expects 20. Consequently, replacingOccurrences makes no change, the value remains 2 (.closed), and this newly added test always fails at the .unknown assertion. Mutate the parsed JSON or match the actual generated whitespace and assert that the replacement occurred.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-door-unknown-20260309 # Conflicts: # KiaTests/UIComponentMockDataTests.swift
Summary
ChargingDoor.State = 0decoding toChargeDoorStatus.unknown.unknownraw value0VehicleTypes.swiftTesting
xcodebuild test -project KiaMaps.xcodeproj -scheme KiaMaps -only-testing:KiaTests/MockVehicleDataTests