Skip to content

Revert AgentCore collector build job - #916

Merged
liustve merged 1 commit into
aws-observability:mainfrom
liustve:codex/revert-agentcore-collector-build
Oct 5, 2026
Merged

Revert AgentCore collector build job#916
liustve merged 1 commit into
aws-observability:mainfrom
liustve:codex/revert-agentcore-collector-build

Conversation

@liustve

@liustve liustve commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Reverting the AgentCore collector build job until it is needed in the future, as there is no plan yet for a managed collector.

@liustve
liustve requested a review from a team as a code owner October 5, 2026 06:20
@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @liustve's task in 26s —— View job

Claude PR Review

  • Read prior reviews on this PR
  • Read the full PR diff
  • Analyze changes
  • Post findings (if any)

Summary: The PR cleanly reverts the AgentCore collector build:

  • Deletes .github/workflows/build-agentcore-collector.yml in full.
  • Removes the corresponding (already-commented-out) build-agentcore-collector job block in .github/workflows/main-build.yml, keeping that file consistent with the deleted workflow it referenced.

The publish-main-build-status job's needs list does not depend on build-agentcore-collector, so removing the commented block doesn't affect job wiring. No functional downstream references to the deleted workflow remain to clean up.

No new issues to flag — nothing to post inline.
• Branch: codex/revert-agentcore-collector-build

@liustve liustve added the skip changelog doesn't need a CHANGELOG entry label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @liustve's task in 31s —— View job

Claude PR Review

  • Read prior reviews on this PR
  • Read the full PR diff
  • Analyze changes
  • Post findings (if any)

Summary: Clean revert of the AgentCore collector build:

  • Deletes .github/workflows/build-agentcore-collector.yml in full (102 lines).
  • Removes the already-commented-out build-agentcore-collector job block from .github/workflows/main-build.yml (11 lines), keeping that file consistent with the deleted workflow it referenced.

Checked for leftover references across .github/ — no remaining mentions of agentcore-collector, build-agentcore-collector, or otelcol-agentcore. The publish-main-build-status job's needs list does not include build-agentcore-collector, so no job wiring is broken.

No new issues to flag — nothing to post inline.
• Branch: codex/revert-agentcore-collector-build

@liustve liustve mentioned this pull request Oct 5, 2026
Merged
@liustve
liustve merged commit f66099e into aws-observability:main Oct 5, 2026
157 of 253 checks passed
wangzlei pushed a commit that referenced this pull request Oct 5, 2026
@liustve
fix(ci): prevent label changes from canceling PR tests (#917)
7f50071 
Adding a PR label currently cancels the full build and test run because
both runs share a concurrency group. This happened when `skip changelog`
was added to #916.

Give label-triggered runs a separate concurrency group so they cannot
cancel full builds. Report their result as `label-checks-pass` so they
do not overwrite `all-pr-checks-pass`. Keep the existing label-based
test skipping.

Use `endsWith(github.event.action, 'labeled')` to recognize both
`labeled` and `unlabeled`, with comments explaining the separate groups
and results.

Validation: actionlint using the CI flags, codespell, and
concurrency/result-name checks for all six PR event types. The shorter
expressions produce the same group and result names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangzlei wangzlei wangzlei approved these changes

Assignees

No one assigned

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liustve @wangzlei