Fix Log Prefix Formation with Multi-Account Organization Support in C… - #2815
Open
laiquesantana wants to merge 1 commit into
Open
Fix Log Prefix Formation with Multi-Account Organization Support in C…#2815laiquesantana wants to merge 1 commit into
laiquesantana wants to merge 1 commit into
Conversation
stobrien89
requested changes
Jul 27, 2026
stobrien89
left a comment
stobrien89
left a comment
Member
There was a problem hiding this comment.
Hi @laiquesantana,
Apologies for the delay. I'm not familiar with the specific cloudtrail setting you mentioned, but it seems like this should be configurable (pass in the prefix) or somehow based on whether or not the setting is enabled.
| // For internal use | ||
| const DEFAULT_TRAIL_NAME = 'Default'; | ||
| const PREFIX_TEMPLATE = 'prefix/AWSLogs/account/CloudTrail/region/date/'; | ||
| const PREFIX_TEMPLATE = 'prefix/AWSLogs/organization/account/CloudTrail/region/date/'; |
Member
There was a problem hiding this comment.
This might be a breaking change. Is there a way to tell if 'Enable for all accounts in my organization' is enabled first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a necessary change to the AWS SDK PHP to address an issue encountered during the configuration of AWS CloudTrail with the 'Enable for all accounts in my organization' option. This setting introduces an additional directory layer after AWSLogs to accommodate organization IDs, which was not accounted for in the existing SDK logic. As a result, log retrieval for multi-account setups within an organization was failing. The implemented fix normalizes the log prefix, ensuring that the SDK can successfully access and iterate over log files in S3 buckets across multiple AWS accounts with the organization feature enabled.
Impact:
This update ensures seamless functionality for new multi-account organizational setups while preserving the behavior for existing single-account implementations. It's an optional adjustment that only affects users who opt into organization-level logging.