Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ def __init__(
self.converter = converter or AgentCoreMemoryConverter
self.config = agentcore_memory_config
self.persistence_mode = agentcore_memory_config.persistence_mode
self.memory_client = MemoryClient(region_name=region_name)
session = boto_session or boto3.Session(region_name=region_name)
self.memory_client = MemoryClient(region_name=region_name, boto3_session=session)
self.has_existing_agent = False

# Instance-scoped monotonic-timestamp state. Per-instance so concurrent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,26 @@ def test_init_basic(self, agentcore_config):

assert manager.config == agentcore_config
assert manager.memory_client == mock_client
mock_client_class.assert_called_once_with(region_name=None)
# MemoryClient must receive the resolved boto3 session so it does not
# build its clients from a different (default) session.
mock_client_class.assert_called_once_with(region_name=None, boto3_session=mock_session)

def test_init_passes_boto_session_to_memory_client(self, agentcore_config):
"""A user-provided boto_session must be passed through to MemoryClient (issue #681)."""
with patch("bedrock_agentcore.memory.integrations.strands.session_manager.MemoryClient") as mock_client_class:
mock_client_class.return_value = Mock()
user_session = Mock()
user_session.region_name = "eu-west-1"
user_session.client.return_value = Mock()

with patch(
"strands.session.repository_session_manager.RepositorySessionManager.__init__", return_value=None
):
AgentCoreMemorySessionManager(agentcore_config, boto_session=user_session)

# The user's session (not a default boto3.Session) must reach MemoryClient.
_, kwargs = mock_client_class.call_args
assert kwargs["boto3_session"] is user_session

def test_events_to_messages(self, session_manager):
"""Test converting Bedrock events to SessionMessages."""
Expand Down
Loading