Skip to content

fix(ci): require approval before publishing Python SDK releases - #692

Merged
aidandaly24 merged 1 commit into
aws:mainfrom
aidandaly24:fix/release-publish-approval
Oct 5, 2026
Merged

aidandaly24 merged 1 commit into
aws:mainfrom
aidandaly24:fix/release-publish-approval

Conversation

@aidandaly24

Copy link
Copy Markdown
Contributor

Summary

  • Route the release approval checkpoint through the existing protected manual-approval environment instead of pypi-approval.
  • Keep the pypi publishing environment and OIDC trusted publishing configuration unchanged.
  • This is a repository-only change; no GitHub environment settings are modified.

Validation

  • git diff --check origin/main...HEAD passed.
  • Parsed the workflow YAML and verified that only the approval environment changes, the publish job still depends on release approval, and the PyPI environment remains unchanged.
  • Confirmed that the existing manual-approval environment has required reviewers.
  • No release workflow was triggered; SDK tests were not run for this workflow-only change.

@aidandaly24
aidandaly24 requested a review from a team October 5, 2026 16:02
@github-actions github-actions Bot added the size/xs PR size: XS label Oct 5, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Oct 5, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 5, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b2a094d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage        ?   89.54%           
=======================================
  Files           ?      124           
  Lines           ?    10727           
  Branches        ?     1676           
=======================================
  Hits            ?     9605           
  Misses          ?      734           
  Partials        ?      388           
Flag Coverage Δ
unittests 89.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aidandaly24
aidandaly24 merged commit 2225a97 into aws:main Oct 5, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants