Repository navigation
feat(evaluation): surface batch evaluation insight results - #704
Merged
Merged
Conversation
vchen5938
had a problem deploying
to
auto-approve
October 19, 2026 23:14 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
✅ No Breaking Changes DetectedNo public API breaking changes found in this PR. |
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
nborges-aws
requested changes
Oct 20, 2026
nborges-aws
left a comment
nborges-aws
left a comment
Contributor
There was a problem hiding this comment.
CI is failling, looks like deepeval version in the eval runner is outside of the range that our repo allows.
Additionally, can we add an example to docs/examples/
GetBatchEvaluation returns insightResults when a batch evaluation includes an analysis evaluator such as Builtin.FailureAnalysis, but BatchEvaluationRunner built its result from a fixed set of response fields and dropped them. Add models for the insight shapes and an insight_results field on BatchEvaluationResult. An absent field and an empty list mean different things, so the runner keeps them distinct: None when no analysis evaluator ran or its results could not be read, and an empty list when the analysis ran and found no failures. The insight shapes reach the client through the service model that botocore ships, so raise the boto3 and botocore floors to the first release that carries them.
vchen5938
force-pushed
the
feat/batch-insight-results
branch
from
October 20, 2026 05:35
3778e32 to
b45367d
Compare
vchen5938
had a problem deploying
to
auto-approve
October 20, 2026 05:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
The insight results example added two evaluators but said only "add one", leaving it unclear which of them produces the insights.
vchen5938
had a problem deploying
to
auto-approve
October 20, 2026 06:05 — with
GitHub Actions
Failure
GitHub Actions
Failure
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Author
I have added examples. The CI failure seems unrelated to my change and it's pre-existing (see this PR). We can discuss the failure separately. |
nborges-aws
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetBatchEvaluation returns insightResults when a batch evaluation includes an analysis evaluator such as Builtin.FailureAnalysis, but BatchEvaluationRunner built its result from a fixed set of response fields and dropped them.
Add models for the insight shapes and an insight_results field on BatchEvaluationResult. An absent field and an empty list mean different things, so the runner keeps them distinct: None when no analysis evaluator ran or its results could not be read, and an empty list when the analysis ran and found no failures.
The insight shapes reach the client through the service model that botocore ships, so raise the boto3 and botocore floors to the first release that carries them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.