Repository navigation
Conversation
kmcginnes
marked this pull request as ready for review
November 13, 2026 23:38
A fixable CRITICAL finding is what calls for a patch release, so the release image scan reports and fails on CRITICAL only. The snapshot scan keeps every severity.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daily image audit scans only
latest-SNAPSHOT, so the published release image is never scanned after it ships. A newrelease-image-auditjob scans it every day and on manual runs. The snapshot job is unchanged.limit-severities-for-sarifis set, because the action otherwise writes every severity to SARIF.TRIVY_IMAGE_SRC=remotemakes Trivy pull from the registry rather than any local copy.workflow_run. That trigger fires after every publish, and snapshot publishes don't move the release tags. The daily schedule picks up a new release within a day, and a manual run picks it up sooner.Evidence
Verified live: ran the job's resolve script against ECR Public (read-only). It picked
3.3.2, andlatest,3.3.2, andsagemaker-3.3.2share one digest. With one digest swapped for another tag's, the mismatch outputs turnedtrue, and a missing tag stopped the step. Ran Trivy with--image-src remoteagainstlatestat the CRITICAL gate's settings, and it passes today. actionlint, with shellcheck, passes.Merge Danger
Door: two-way
Impact: CI-only. It adds a daily job that fails when the newest release has a fixable CRITICAL finding.
Related
🤖 Written by an AI agent on my behalf.