Repository navigation
Conversation
kmcginnes
marked this pull request as ready for review
November 13, 2026 23:39
kmcginnes
force-pushed
the
check-release-image-publish-3.3.x
branch
from
November 13, 2026 23:47
51a8247 to
774f729
Compare
A two-platform build with the arm64 stages under emulation takes about 5 to 7 minutes, so 20 minutes leaves 3x headroom.
read -ra splits TAGS explicitly, so the push and verify steps quote every use and need no ShellCheck exception.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
3.3.xpatch is published by dispatchingbuild_docker.ymlon its tag, and the run uses the tag's copy of the workflow, so3.3.xneeds the same release checks asmain(#2603). Without them, a 3.3.x patch released after 3.4.0 would movelatestback to 3.3.Three commits:
The workflow and the script match #2603. The changes for this branch's older toolchain:
The root
vitest.config.tslists.github/scriptsas a project, the root gets@types/node, anddocs/agents/testing.mdlists the new project.Evidence
Before: nothing checked the ref or the version, and
latestmoved on every release run.After: the same
releaseImage.test.tscases as #2603 pass under this branch's Vitest.Verified live: the read-only checks ran against the public ECR Public API in #2603, with the same script. No image was built or pushed, and the workflow was not run.
Run locally on this branch, on Node 24.21.0 from
.node-version:pnpm checks,pnpm test, andpnpm buildpass, and actionlint passes on the workflow. A type error and a lint error planted in the script were each caught, so both checks cover.github/scripts.pnpm dedupe --checkfails on this branch with or without this change.Merge Danger
Door: two-way
Impact: release process
A 3.3.x release dispatched on the branch now fails. Dispatch on the
v<version>tag instead. A 3.3.x patch moveslatestonly while 3.3 is the highest published line.Related
🤖 Written by an AI agent on my behalf.