Skip to content

Check the tag, version, and latest tags before publishing a 3.3.x release image - #2604

Open
kmcginnes wants to merge 5 commits into
3.3.xfrom
check-release-image-publish-3.3.x
Open

kmcginnes wants to merge 5 commits into
3.3.xfrom
check-release-image-publish-3.3.x

Conversation

@kmcginnes

@kmcginnes kmcginnes commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A 3.3.x patch is published by dispatching build_docker.yml on its tag, and the run uses the tag's copy of the workflow, so 3.3.x needs the same release checks as main (#2603). Without them, a 3.3.x patch released after 3.4.0 would move latest back to 3.3.

Three commits:

1. build_docker.yml: concurrency and timeout-minutes from #2537
     a release run gets its own concurrency group, so a merge can't cancel it
     the job times out after 20 minutes, 3x the emulated two-platform build
2. .github/scripts/releaseImage.ts and its tests, as on main
3. build_docker.yml: release mode plans, pushes, and verifies its tags, as on main

The workflow and the script match #2603. The changes for this branch's older toolchain:

-.github/scripts/vite.config.ts       (vite-plus)
+.github/scripts/vitest.config.ts     (vitest/config)
-import { … } from "vite-plus/test";
+import { … } from "vitest";
-"typecheck": "tsc --noEmit",
+"typecheck": "tsc --noEmit && tsc --noEmit -p .github/scripts",

The root vitest.config.ts lists .github/scripts as a project, the root gets @types/node, and docs/agents/testing.md lists the new project.

Evidence

Before: nothing checked the ref or the version, and latest moved on every release run.
After: the same releaseImage.test.ts cases as #2603 pass under this branch's Vitest.

Verified live: the read-only checks ran against the public ECR Public API in #2603, with the same script. No image was built or pushed, and the workflow was not run.

Run locally on this branch, on Node 24.21.0 from .node-version: pnpm checks, pnpm test, and pnpm build pass, and actionlint passes on the workflow. A type error and a lint error planted in the script were each caught, so both checks cover .github/scripts. pnpm dedupe --check fails on this branch with or without this change.

Merge Danger

Door: two-way

Impact: release process

A 3.3.x release dispatched on the branch now fails. Dispatch on the v<version> tag instead. A 3.3.x patch moves latest only while 3.3 is the highest published line.

Related


🤖 Written by an AI agent on my behalf.

@kmcginnes
kmcginnes marked this pull request as ready for review November 13, 2026 23:39
@kmcginnes
kmcginnes force-pushed the check-release-image-publish-3.3.x branch from 51a8247 to 774f729 Compare November 13, 2026 23:47
A two-platform build with the arm64 stages under emulation takes about 5 to 7 minutes, so 20 minutes leaves 3x headroom.
read -ra splits TAGS explicitly, so the push and verify steps quote every use and need no ShellCheck exception.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant