Repository navigation
Conversation
Layer: 8-env-default-connection
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default Connection settings such as
GRAPH_CONNECTION_URLwere read only from-eflags andconfig.json. They now also come from.envand.env.local, in the same precedence order as every other setting.Upgrade notes
.envand.env.localnow take effect. The image's own.envsetsSERVICE_TYPE=neptune-dbandGRAPH_EXP_FETCH_REQUEST_TIMEOUT=240000, the same as the defaults. Remove connection settings from a mounted.envthat you don't want used.Evidence
After: the scenario rows with connection settings in
.envand.env.localnow expect them in the/defaultConnectionbody, behind-eandconfig.json.Verified live: an image built from this PR on Colima passes every container step of the Docker workflow.
Merge Danger
Door: two-way
Impact: a mounted
.envwith leftover connection settings now changes the Default Connection.Related
🤖 Written by an AI agent on my behalf.