Skip to content

Publish amd64 and arm64 Docker images on 3.3.x - #2615

Open
kmcginnes wants to merge 4 commits into
3.3.xfrom
publish-arm64-images-3.3.x
Open

kmcginnes wants to merge 4 commits into
3.3.xfrom
publish-arm64-images-3.3.x

Conversation

@kmcginnes

@kmcginnes kmcginnes commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

3.3.3 ships from 3.3.x, so this brings the two-platform image publish from Publish amd64 and arm64 Docker images (#2614) to this branch. Docker on arm64 can't pull 3.3.1 or 3.3.2, because each is an image index with one amd64 image and a provenance attestation entry, and no arm64 entry.

 build_docker.yml
+  Set up QEMU (arm64)
+  Set up Docker Buildx
-  docker build, docker tag, docker push × 2
+  docker buildx build --platform linux/amd64,linux/arm64 -t <tag> -t sagemaker-<tag> --push
   release only:
-    docker tag, docker push × 2
+    docker buildx imagetools create -t latest -t sagemaker-latest <tag>

The Dockerfile now builds the client once on the build host. It was a single stage, so for arm64 the whole client build (pnpm install, pnpm build) ran under QEMU on the x86 runner. Emulated, that build is slow enough to hang: the first run of this PR stopped after rendering chunks... and sat until GitHub's 6-hour limit. Like main's Dockerfile after #2614, it now has three parts:

 base (per platform): Amazon Linux, Node.js for the platform, corepack, package managers removed
+build (FROM --platform=$BUILDPLATFORM): Node.js and corepack for the build host,
+  pnpm install, pnpm build, node_modules removed
 runtime (FROM base):
-  COPY . , pnpm install, pnpm build, node_modules removed,
+  COPY --from=build,
   pnpm install --prod, npm, corepack, and pnpm removed

The production install still runs on the target platform, so a platform-specific package matches it. NODE_VERSION and the corepack version moved to ARGs before the first FROM, so both stages install the same ones. This branch keeps corepack's pnpm rather than the Vite+ image main builds in.

test_build_docker.yml also builds the arm64 image. It checks the image's architecture, that its Node.js is the Dockerfile's NODE_VERSION built for arm64, and that the server answers /status and /explorer/. This branch's .node-version (24.21.0) differs from the Dockerfile's NODE_VERSION (24.22.2), so the check reads the Dockerfile. The job now stops after 30 minutes, so a hung build can't hold a runner for 6 hours again. The binfmt and BuildKit images the setup actions run are pinned by digest.

Check the tag, version, and latest tags before publishing a release image (#2603) and its backport change the same push steps. Whichever merges second rebases onto a small conflict.

Evidence

Before: public.ecr.aws/neptune/graph-explorer:3.3.2 is an image index with linux/amd64 and unknown/unknown only. On the x86 runner, the arm64 build ran for 6 hours and was cancelled.
After: docker buildx build --platform linux/amd64,linux/arm64 builds this branch. The arm64 image reports linux/arm64 and Node.js v24.22.2 arm64, and the amd64 one v24.22.2 x64. Both answer /status and return 200 for /explorer/.

Verified live: on an arm64 host, a --no-cache build of both platforms took 61 s, with amd64 emulated, and the build stage ran once. Both images have openssl and no npm, pnpm, corepack, python3, yum, or dnf. The amd64 image's /graph-explorer has the same 40,039 files as an amd64 image built from 3.3.x, with the same client bundle and the same Node.js binary. The only differences are the Dockerfile itself, timestamps in pnpm's state files and an npm log name, and an empty .cache/rosetta directory the local emulator left in the old image. Trivy at HIGH and CRITICAL passes on the new amd64 image. pnpm checks and pnpm test pass on this branch.

Merge Danger

Door: two-way

Impact: publishing

The next release dispatch on this branch publishes a two-platform index under the version and latest tags.

Related


🤖 Written by an AI agent on my behalf.

@kmcginnes
kmcginnes marked this pull request as ready for review November 14, 2026 00:16
The arm64 image built the whole client under emulation, which ran for hours on an x86 runner. Only the production install, Node.js, and the runtime now run per platform.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant