Repository navigation
Conversation
kmcginnes
marked this pull request as ready for review
November 14, 2026 00:16
The arm64 image built the whole client under emulation, which ran for hours on an x86 runner. Only the production install, Node.js, and the runtime now run per platform.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3.3.3 ships from
3.3.x, so this brings the two-platform image publish from Publish amd64 and arm64 Docker images (#2614) to this branch. Docker on arm64 can't pull3.3.1or3.3.2, because each is an image index with one amd64 image and a provenance attestation entry, and no arm64 entry.The
Dockerfilenow builds the client once on the build host. It was a single stage, so for arm64 the whole client build (pnpm install,pnpm build) ran under QEMU on the x86 runner. Emulated, that build is slow enough to hang: the first run of this PR stopped afterrendering chunks...and sat until GitHub's 6-hour limit. Likemain'sDockerfileafter #2614, it now has three parts:The production install still runs on the target platform, so a platform-specific package matches it.
NODE_VERSIONand the corepack version moved toARGs before the firstFROM, so both stages install the same ones. This branch keeps corepack's pnpm rather than the Vite+ imagemainbuilds in.test_build_docker.ymlalso builds the arm64 image. It checks the image's architecture, that its Node.js is theDockerfile'sNODE_VERSIONbuilt forarm64, and that the server answers/statusand/explorer/. This branch's.node-version(24.21.0) differs from theDockerfile'sNODE_VERSION(24.22.2), so the check reads theDockerfile. The job now stops after 30 minutes, so a hung build can't hold a runner for 6 hours again. The binfmt and BuildKit images the setup actions run are pinned by digest.Check the tag, version, and latest tags before publishing a release image (#2603) and its backport change the same push steps. Whichever merges second rebases onto a small conflict.
Evidence
Before:
public.ecr.aws/neptune/graph-explorer:3.3.2is an image index withlinux/amd64andunknown/unknownonly. On the x86 runner, the arm64 build ran for 6 hours and was cancelled.After:
docker buildx build --platform linux/amd64,linux/arm64builds this branch. The arm64 image reportslinux/arm64and Node.jsv24.22.2 arm64, and the amd64 onev24.22.2 x64. Both answer/statusand return 200 for/explorer/.Verified live: on an arm64 host, a
--no-cachebuild of both platforms took 61 s, with amd64 emulated, and the build stage ran once. Both images have openssl and no npm, pnpm, corepack, python3, yum, or dnf. The amd64 image's/graph-explorerhas the same 40,039 files as an amd64 image built from3.3.x, with the same client bundle and the same Node.js binary. The only differences are theDockerfileitself, timestamps in pnpm's state files and an npm log name, and an empty.cache/rosettadirectory the local emulator left in the old image. Trivy at HIGH and CRITICAL passes on the new amd64 image.pnpm checksandpnpm testpass on this branch.Merge Danger
Door: two-way
Impact: publishing
The next release dispatch on this branch publishes a two-platform index under the version and
latesttags.Related
🤖 Written by an AI agent on my behalf.