Repository navigation
fix(graph-explorer): show filter-specific toast when expand matches no neighbors - #2618
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
…o neighbors When expanding a node's neighbors with attribute filters, an empty result set previously triggered 'No more neighbors to expand', misleading users into believing the node was exhausted rather than filtered. Check attributeFilters on the expansion request: if filters were applied, show 'No neighbors matched your filters'; otherwise keep 'No more neighbors to expand'. Fixes aws#2060 Signed-off-by: Suprovo Mallick (DYNO) <143953131+DYNOSuprovo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2060
When expanding a node's neighbors with attribute filters, an empty result set previously triggered the toast:
This implied the node's neighbors were exhausted, when in reality neighbors existed but were excluded by the active filters.
Changes
packages/graph-explorer/src/hooks/useExpandNode.tsx:expandNode(single expand), checkrequest.attributeFilters: if present and non-empty, show toastNo neighbors matched your filters; otherwise displayNo more neighbors to expand.expandNodes(multi expand), checkfilters.attributeFilters: if present and non-empty, show toastNo neighbors matched your filters; otherwise displayNo more neighbors to expand.packages/graph-explorer/src/hooks/useExpandNode.test.ts:No neighbors matched your filters.No more neighbors to expand.No neighbors matched your filters.