Skip to content

Fail release branch image builds on CRITICAL findings only - #2621

Open
kmcginnes wants to merge 1 commit into
mainfrom
critical-only-image-scan-on-release-branches
Open

kmcginnes wants to merge 1 commit into
mainfrom
critical-only-image-scan-on-release-branches

Conversation

@kmcginnes

Copy link
Copy Markdown
Collaborator

Summary

A release branch only takes a patch release for a fixable CRITICAL finding, so its pull requests shouldn't fail the image test build on anything less. Pull requests into main still fail on fixable MEDIUM and up.

severity: ${{ github.event_name == 'pull_request' && github.base_ref != 'main' && 'CRITICAL' || 'MEDIUM,HIGH,CRITICAL' }}
  • 3.3.x keeps its own copy of the workflow, which gets the same change in its own pull request. This change is for the next release branch, 3.4.x, which is cut from main and would otherwise fail on MEDIUM.
  • A manual run counts as main, and fails on MEDIUM and up.

Evidence

Verified: the workflow is valid YAML and formatted. actionlint reports only the two existing shellcheck notes about unused loop variables, on lines this change doesn't touch.

Merge Danger

Door: two-way

Impact: CI-only. Pull requests into release branches stop failing on fixable MEDIUM and HIGH findings.

Related


🤖 Written by an AI agent on my behalf.

A release branch only takes a patch for a CRITICAL finding. Pull requests into main still fail on MEDIUM and up.
@kmcginnes
kmcginnes marked this pull request as ready for review November 16, 2026 23:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant