Repository navigation
fix(inference-operator): update Helm to EKS add-on migration script - #473
Open
ShreyaGangishetty wants to merge 1 commit into
Open
ShreyaGangishetty wants to merge 1 commit into
ShreyaGangishetty wants to merge 1 commit into
Conversation
fix(inference-operator): update Helm to EKS add-on migration script.
XuanCS
approved these changes
Oct 23, 2026
can-sun
approved these changes
Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Updates the Helm → EKS add-on migration for the HyperPod Inference Operator
(
helm_chart/HyperPodHelmChart/charts/inference-operator/migration/). The script had drifted from the currentadd-on, and several steps could leave a live cluster without metrics or with broken webhooks.
pinned
v1.0.0-eksbuild.1, which is not available on Kubernetes 1.35+. Overridable with--addon-version.Configuration follows the current schema and sets
inferenceGateway.enabled: false(v2.x enables it bydefault; it was never part of the Helm install).
--execution-role-arn,--alb-role-arn,--keda-role-arn,--jumpstart-gated-role-arn. Roles that are not provided are created with the add-on's trust andpermissions, instead of copying attached policies from the Helm-era roles (which produced a KEDA role with no
permissions when the Helm role used inline policies).
the add-on service accounts, S3 access to every TLS bucket in use, and ACM import/tag/delete. Detected
problems are never auto-approved by
--auto-approve.--preserve(the add-on owns the inference CRDs), re-applies the Helmrelease so the webhooks, KEDA metrics APIService and CRD conversion webhook point back at the Helm
controllers, waits for them, then removes the add-on controllers. Deletes only roles and tags the script
created. Model resources are saved to the backup directory and never deleted.
--resolve-conflicts OVERWRITEand waited on before the Helmmetrics-server is removed. Previously it went
CREATE_FAILEDafter the Helm one was deleted, leaving thecluster without a metrics API.
your own and
alb-controller-policy.json), what to know before and after migrating, and recovery.Before/After UX
Before:
v1.0.0-eksbuild.1with the Inference Gateway implicitly on (v2.x defaults)After:
./helm_to_addon.sh --cluster-name <cluster> --region <region>installs the default add-on version with thegateway disabled
How was this change tested?
End to end on a HyperPod EKS cluster (Kubernetes 1.34, us-east-1) created with the console quick-setup Helm
path, with a JumpStart model and an InferenceEndpointConfig (2 replicas each) under continuous
InvokeEndpointload (2 req/s per endpoint):--addon-version--auto-approvecreate-addonfails after Helm controllers are scaled down--preserve, webhooks/APIService/CRD conversion back on Helm, new model deploys on Helm--preserveand recreatedNo endpoint request failed in any scenario (two failures over the whole run were the load client's own
credentials expiring). Model resource UIDs were unchanged through every migration and rollback.
Are unit tests added?
No. The script has no unit test harness; it was tested end to end as above.
Are integration tests added?
No.
Reviewer Guidelines
One of the following must be true: