Skip to content

docs(commit-signing): document how pull requests merge under the rule - #7

Open
estefano-vechietti-azion wants to merge 1 commit into
mainfrom
docs/commit-signing-merge-methods
Open

estefano-vechietti-azion wants to merge 1 commit into
mainfrom
docs/commit-signing-merge-methods

Conversation

@estefano-vechietti-azion

Copy link
Copy Markdown
Contributor

What changes

The guide gains a Merging pull requests section and three rows in Common problems, based on a test on a scratch repository whose ruleset only has required_signatures and no bypass:

Case Result
Unsigned commit already on main Left as is; it did not block anything after it
PR with an unsigned commit, squash Merged; the squashed commit is verified: true, reason: valid, committed by GitHub
PR with an unsigned commit, merge commit Refused: Commits must have verified signatures
PR, rebase Refused: Rebase merges cannot be automatically signed by GitHub
Direct unsigned push to main Refused: GH013 ... Commits must have verified signatures

It also notes that gh pr merge --squash refuses on its own pre-check (mergeStateStatus: BLOCKED), while the same merge through the API succeeds.

Not tested: a merge commit where every commit is signed, which is expected to pass.

🤖 Generated with Claude Code

Tested on a scratch repository with a ruleset that only requires
signatures: squash merges pass with unsigned commits (GitHub signs the
result), merge commits are refused unless every commit is signed, and
rebase merges are always refused because GitHub cannot sign rebased
commits. Existing history is not checked again. gh pr merge --squash
refuses on its own pre-check while the API merge is allowed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@estefano-vechietti-azion
estefano-vechietti-azion requested a review from a team as a code owner November 3, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant