Repository navigation
fix(storybook): stop stale deploys from breaking stories and fix broken story assets - #1157
Open
isaque-bock-azion wants to merge 3 commits into
Open
isaque-bock-azion wants to merge 3 commits into
isaque-bock-azion wants to merge 3 commits into
Conversation
…ments fresh Each azion deploy uploads the build under a new storage prefix but skips the purge step, so the edge kept serving the previous iframe.html for up to two hours. That stale HTML pointed at hashed story chunks that no longer exist in the new prefix, and every story failed with "Failed to fetch dynamically imported module" (404 NoSuchKey). The workflow now purges webkit.azion.app after the deploy, and HTML, JSON indexes, the unhashed sb-manager/sb-addons bundles and the SPA rewrite get a short cache policy (browser 0s, edge 60s). Hashed assets keep the 2h policy.
…felist new motion utilities The FeatureTiles, NetworkSection and MediaSplitStack Types stories rendered site paths (/marketing-components/...) that do not exist in Storybook, so their images 404ed. withTemplateAssets swaps those paths for the bundled assets in the rendered template only, keeping the site paths in Show code; MediaSplitStack now resolves its bound bands through withStoryAssets. The Motion overview threw on import because the theme gained page-enter, content-enter, texture-wave-a, texture-wave-b and brand-marquee without them being added to TAILWIND_ANIMATE_SAFELIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed to fetch dynamically imported module: eachazion deployuploads to a new storage prefix without purging, so the edge kept a 2h-cachediframe.htmlpointing at chunks that no longer exist (404NoSuchKey). The workflow now purgeswebkit.azion.appafter deploy, and HTML/JSON/unhashed manager bundles get a short cache policy.Typesstories of FeatureTiles, NetworkSection and MediaSplitStack rendered site paths (/marketing-components/...) that 404 in Storybook; they now render the bundled assets while "Show code" keeps the site paths.TAILWIND_ANIMATE_SAFELIST.How to test
pnpm storybook:build, then serveapps/storybook/dist: every story renders (checked headlessly: 855/855 stories, no page errors and no 404 image URLs).Components/Sections/FeatureTiles › Types,NetworkSection › TypesandMediaSplitStack › Types: all illustrations and logos load; "Show code" still shows/marketing-components/...paths.Foundations/Design tokens/Motion: the page loads and listspage-enter,content-enter,texture-wave-a,texture-wave-b,brand-marquee.Deploy Application Storybookrun ends with the newPurge edge cachestep green, andhttps://webkit.azion.app/?path=/docs/templates-marketing-comparesupporttiers--docsloads.Notes
apps/storybookand.githubonly).