Skip to content

chore: migrate JavaScript actions to Node 24 - #188

Merged
freben merged 1 commit into
mainfrom
freben/node24-runtime
Sep 4, 2026
Merged

chore: migrate JavaScript actions to Node 24#188
freben merged 1 commit into
mainfrom
freben/node24-runtime

Conversation

@freben

@freben freben commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • migrate the six remaining JavaScript actions from the Node 20 runtime to Node 24
  • retain Node 20 as a comparison leg while adding Node 24 to CI
  • update CI to immutable Node 24-capable checkout and setup-node v7 revisions
  • restrict CI permissions to read-only contents and disable persisted checkout credentials

pr-automation already targets Node 24 after #187. yarn-install is a composite action and is intentionally unchanged.

Consumer impact

The intended consumers are backstage/backstage and backstage/community-plugins, both on GitHub-hosted runners. Current active usage covers changeset-feedback, cron, pr-automation, and pr-sync; migrating the remaining dormant JavaScript manifests keeps the next release internally consistent.

This PR intentionally leaves dependency modernization and composite-action changes for separate follow-ups. The existing Octokit stack emits Node's DEP0040 warning for its transitive punycode dependency under Node 24, but the warning is non-fatal and the full suite passes.

This supersedes the runtime-manifest scope proposed in #166 and the pr-sync runtime scope in #186.

Validation

  • Node 20.20.2: 23 suites, 121 tests passed
  • Node 24.16.0: 23 suites, 121 tests passed
  • all eight action manifests and the CI workflow parse as YAML
  • all JavaScript action manifests resolve to node24; yarn-install remains composite

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

@carlerikjohan carlerikjohan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you can run different variations 😄 LGTM!

@freben
freben merged commit 5010785 into main Sep 4, 2026
3 checks passed
@freben
freben deleted the freben/node24-runtime branch September 4, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants