Fix rclone mover crash on PVCs with symlinks - #2082
Conversation
Exclude symlinks from the getfacl pipeline in active.sh. On UBI9's acl-2.4.0, getfacl -P returns ELOOP on symlinks, killing the script under pipefail before rclone sync runs. Symlinks have no meaningful ACLs so skipping them loses no data. Adds e2e test with dangling and relative symlinks on the source PVC. Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: falconizmi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
|
/lgtm |
|
/retest |
|
@falconizmi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
2 participants
Summary
acl-2.4.0,getfacl -Preturns ELOOP on symlinks, killing the script underpipefail.find | getfaclpipeline. Symlinks have no meaningful ACLs.Notes
release-0.16andrelease-0.15after merge.