Repository navigation
Windows: don't hand out the engine's accessibility tree - #889
Merged
Merged
Conversation
Another app's UI Automation hit test crashed the app in the engine's FlutterPlatformNodeDelegateWindows::HitTestSync (a child AX node with no delegate, flutter/flutter#195653). The engine also turns semantics on at the first such query and keeps them on. The app makes no claim to support screen readers, so the view no longer hands out its accessibility tree. Co-Authored-By: BaoCode <noreply@baocode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crash report (Windows 10, 1.9.3+29) symbolized to
flutter_windows.dllFlutterPlatformNodeDelegateWindows::HitTestSync, called fromAXPlatformNodeWin::accHitTestthrough OLEACC/UIAutomationCore: another app's hit test met a child AX node with no delegate and dereferenced null (flutter/flutter#195653, unguarded on master too).The view's procedure now answers
WM_GETOBJECTwithDefWindowProcW, so the engine never builds the AX tree or turns semantics on (which also removes the per-frameflushSemanticscost seen in earlier hang reports). The app makes no claim to support screen readers.🤖 Generated with BaoCode