Repository navigation
Show images in Local Changes as pictures, as Review does - #94
Merged
Merged
Conversation
An untracked docs/images/muffin-farro.jpeg showed "Binary content · No inline preview" in Diff and "Binary content" in Full file. The diff worker built the image preview only for Review, whose sides are blobs. gg_git::working_diff::preview_bytes now reads a working comparison's sides (staged: base tree and index; unstaged: index and the working file; untracked: the working file), and binary_preview::read_working decodes them, so Local Changes shows the same image comparison. The header names each side's source: Before HEAD/index, After index/working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WX3sFiNbkTC6gZUVCPGT3o
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WX3sFiNbkTC6gZUVCPGT3o # Conflicts: # docs/screenshots/gg-native-wide.png # docs/verification.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WX3sFiNbkTC6gZUVCPGT3o
worktrees_window_prunes_missing_and_locks_with_a_reason failed on the macOS Intel runner: it stopped waiting once the list was loaded, but the list can arrive after that frame's window was drawn, so the text it checked showed no window yet. The listing and lock steps now also wait for a frame that shows "Missing" and "Locked". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WX3sFiNbkTC6gZUVCPGT3o
Owner
Author
|
CI failed on The test stopped waiting once the worktree list had loaded. The list can arrive after that frame's window has already been drawn, so on the slower runner the text it checked didn't show the Worktrees window yet. The same test passed on this runner in the two earlier runs. 00aa517 makes the listing and lock steps also wait for a frame that shows Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untracked
docs/images/muffin-farro.jpegin Local Changes showed Binary content · No inline preview in Diff and Binary content in Full file. The diff worker only built the image preview for Review, where both sides are Git blobs. In Local Changes the sides are the index and the working file, so it fell back to the text summary.Change
gg_git::working_diff::preview_bytesreads a working comparison's two sides, the same ones the text comparison uses:The working file is read as it is on disk, within the 16 MiB per-side budget.
binary_preview::read_workingdecodes those sides. Local Changes now shows the same Side by side, Swipe, Onion skin and Hex views as Review. Since these sides have no object ID, the header names their source instead:Before HEAD,Before index,After index,After working.New acceptance scenario: CHG-75, "An image in Local Changes shows its picture". I also updated architecture.md, verification.md and the docs site.
Tests
an_untracked_and_a_modified_image_show_their_pictures(status_view.rs) checks the header for each kind of change:After working · 5 × 5Before index · 3 × 2,After working · 6 × 4Before HEAD · 3 × 2,After index · 6 × 4The test fails on the old worker.
Checks
fmt, clippy
-D warnings, all workspace tests, and the README screenshot--checkpass.This branches from
mainand is independent of #93 (rename detection).Generated by Claude Code