Skip to content
This repository was archived by the owner on Oct 9, 2026. It is now read-only.

fix(storage): create file storage directory before use - #72

Merged
danyalprout merged 1 commit into
base:masterfrom
omerbek:fix/file-storage-mkdir
Oct 6, 2026
Merged

danyalprout merged 1 commit into
base:masterfrom
omerbek:fix/file-storage-mkdir

Conversation

@omerbek

@omerbek omerbek commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • create the configured file-storage directory before initializing metadata files
  • cover fresh nested storage directories in FileStorage tests

Fixes #71.

Testing

  • git diff --check

Note: Go is not installed in this Windows environment, so go test ./common/storage/... and gofmt could not be run locally.

@cb-heimdall

cb-heimdall commented Aug 16, 2026 •

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@danyalprout
danyalprout merged commit 0339a21 into base:master Oct 6, 2026
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

file storage crashes on startup when --file-directory does not exist yet

3 participants