fix: remove hardcoded Engine API JWT secret and require explicit configuration#1147
Open
erhnysr wants to merge 1 commit into
Open
fix: remove hardcoded Engine API JWT secret and require explicit configuration#1147erhnysr wants to merge 1 commit into
erhnysr wants to merge 1 commit into
Conversation
…iguration The default BASE_NODE_L2_ENGINE_AUTH_RAW value was a well-known public hex string committed in the repository. Because authrpc binds to 0.0.0.0, any operator using host networking, Kubernetes, custom port mappings, or shared Docker networks was exposed to unauthenticated Engine API access. - Replace hardcoded secret in .env.mainnet and .env.sepolia with a placeholder that instructs operators to generate their own value with `openssl rand -hex 32` - Add validation in execution-entrypoint that exits with a clear error message if BASE_NODE_L2_ENGINE_AUTH_RAW is unset or still holds the placeholder value - Upgrade the existing empty-check in consensus-entrypoint to also catch the placeholder value - Document BASE_NODE_L2_ENGINE_AUTH_RAW as a required field in README.md Fixes base#1086 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening this contribution (previously #1087, closed by stale-bot without review) — removes a hardcoded Engine API JWT secret that exposes authrpc to unauthenticated access when operators use the default .env files. This is a real security gap for node operators running fresh setups. Rebased on latest main, no conflicts. Happy to address any review feedback.