fix: respect pre-set BASE_NODE_P2P_ADVERTISE_IP in consensus-entrypoint#1150
Open
haileymarshall wants to merge 1 commit into
Open
fix: respect pre-set BASE_NODE_P2P_ADVERTISE_IP in consensus-entrypoint#1150haileymarshall wants to merge 1 commit into
haileymarshall wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1107
What changed?
consensus-entrypointnow only runs public IP discovery whenBASE_NODE_P2P_ADVERTISE_IPis not already set. If the operator provided a value, the script logs it and uses it as-is. Behavior when the variable is unset is unchanged: discovery runs against the same four providers and a total failure still exits with code 8.Why?
As reported in #1107, the script unconditionally called
get_public_ipand thenexport BASE_NODE_P2P_ADVERTISE_IP=$PUBLIC_IP, whichHow has it been tested?
bash -nsyntax check.curlin all three scenarios: