Repository navigation
Tidy grid setup's stderr: yellow warning prefix, no statusLine note, spaced notice - #267
Open
sanieldalib wants to merge 3 commits into
Open
sanieldalib wants to merge 3 commits into
sanieldalib wants to merge 3 commits into
Conversation
stderr lines that start with "warning:" now render the prefix in the terminal's yellow (plain when stderr isn't a terminal), and the setup notice gets a blank line before and after so it reads apart from the notes above it and the prompt below. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sanieldalib
force-pushed
the
salib/grid-warning-color
branch
from
November 13, 2026 22:20
1b098f7 to
c99190b
Compare
LogLine and Logf no longer color any line that happens to start with "warning:". Warn and Warnf write the prefix (yellow on a terminal) and the message, every existing warning goes through them, the auth store's warnWriter receives the bare message, and harness plans carry warnings in their own Warnings field instead of prefixed Notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Setup no longer prints "Existing statusLine … left unchanged" when it keeps a user's statusLine and shows the served model through a Stop hook instead. The behaviour is unchanged; it was the last plan note, so Plan.Notes goes too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sanieldalib
marked this pull request as ready for review
November 13, 2026 22:56
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #264.
Three small output tweaks from demoing
grid setup:warning:prefix. Newctx.Warn/ctx.Warnfhelpers writewarning:in the terminal's own yellow (ANSI 3, bold) followed by the message in the normal colour, the same as cargo and Homebrew. Colour is dropped when stderr isn't a terminal, so piped output and tests see plainwarning: …text.warning:line goes through them: grid, model, model environment, predict, ssh, auth and volume transfer. Volume transfer used to printWarning:with a capital W; it now matches the rest.warnWritercallbacks receive the bare message and the CLI adds the prefix.Plan.Warningsfield instead ofNotesstrings with awarning:prefix baked in. Setup prints warnings before notes.LogLine/Logfare unchanged plain writers; nothing is coloured implicitly.Plan.Notesand its print loop are removed.Before:
After (
warning:in bold yellow, the rest unchanged):Existing tests still match the plain
warning:text. Two harness tests now readPlan.Warnings, and the statusLine tests assert the note is gone while still checking the user's statusLine is kept.Test_Grid_Setup_RealHarnessandTest_Grid_ClaudeServedModel_RealClaudeCodefail locally the same way they do on main.🤖 Generated with Claude Code