Repository navigation
fix: preserve dash-prefixed sandbox copy paths #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kayvan-Zahiri
wants to merge
2
commits into
basetenlabs:main
from
Kayvan-Zahiri:codex/copy-dash-paths
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import subprocess | ||
| from pathlib import Path | ||
|
|
||
| import httpx | ||
| import pytest | ||
|
|
||
| from tests.sandbox.test_fs import _body, _Fake, _ok, _process | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("asynchronous", [False, True]) | ||
| @pytest.mark.parametrize( | ||
| ("source", "destination"), | ||
| [("-source", "copy"), ("source", "-destination"), ("-source", "-destination")], | ||
| ) | ||
| @pytest.mark.asyncio | ||
| async def test_copy_preserves_paths_starting_with_dash( | ||
| tmp_path: Path, source: str, destination: str, asynchronous: bool | ||
| ) -> None: | ||
| (tmp_path / source).write_text("file contents") | ||
|
|
||
| def handle(request: httpx.Request) -> httpx.Response: | ||
| if request.method == "POST": | ||
| # Execute the SDK's actual command against local fixture files. | ||
| result = subprocess.run( | ||
| _body(request)["command"], | ||
| shell=True, | ||
| check=False, | ||
| cwd=tmp_path, | ||
| capture_output=True, | ||
| text=True, | ||
| timeout=5, | ||
| ) | ||
| return _ok( | ||
| _process( | ||
| status="completed" if result.returncode == 0 else "failed", | ||
| exitCode=result.returncode, | ||
| stderr=result.stderr, | ||
| ) | ||
| ) | ||
| return _ok(_process()) | ||
|
|
||
| fake = _Fake(handle) | ||
| if asynchronous: | ||
| await fake.async_sandbox().fs.copy(source=source, destination=destination) | ||
| else: | ||
| fake.sandbox().fs.copy(source=source, destination=destination) | ||
| assert (tmp_path / destination).read_text() == "file contents" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just noticed this draft PR. Let me know if this is something you are hitting and when it is ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in production. I found it while reading the copy code: a source path starting with
-gets parsed bycpas an option. It's ready for review now, thanks for taking a look.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, you are not a Baseten user hitting this issue at this time? Or is this just from a scan and you aren't using this code yourself?
This also exists in other SDKs and in Blaxel at https://github.com/blaxel-ai/sdk-python/blob/e9b63fd6bf8eabd02c451510a733e29615644fbf/src/blaxel/core/sandbox/sync/filesystem.py#L175 and in other places. I want to confirm impact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'm not a Baseten user and haven't hit this myself. I found it while reading through sandbox SDK code, so it comes from a review, not a bug report. The impact is small: it only affects a relative path that starts with
-, since absolute paths always start with/. If that isn't worth a change on your side, I'm fine with closing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is less of a concern at this time. I do think we'll close it and when we tackle, we can do it across all 3 SDKs.