Repository navigation
Disable read timeout on default low-level HTTP clients - #40
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes disabling read timeouts on the SDK’s default HTTP clients.
No open issues 🎉
What changed in this PR
Disables read timeouts on the SDK’s default low-level HTTP clients so long-running requests and streams are not interrupted by httpx’s five-second read timeout.
Changes:
- Applies
httpx.Timeout(5.0, read=None)to synchronous and asynchronous inference, management, and sandbox clients. - Preserves five-second connect, write, and pool timeouts.
- Leaves clients supplied through
http_client_overrideunchanged.
| File | Description |
|---|---|
baseten/client/_sandbox.py |
Disables default read timeouts for sandbox calls and streams. |
baseten/client/_management.py |
Disables default read timeouts for management requests. |
baseten/client/_inference.py |
Disables default read timeouts for long-running inference requests. |
Review effort: Balanced
rdingwall
approved these changes
Nov 6, 2026
Collaborator
Author
|
Doing admin bypass, the sandbox tests are too flaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
💻 How
httpx.Timeout(5.0, read=None)when creating the default client; connect, write, and pool keep httpx's 5shttp_client_overrideare unchanged🔬 Testing