Skip to content

Remove sandbox show_secrets option - #45

Merged
cretz merged 1 commit into
mainfrom
cretz/remove-sandbox-show-secrets
Nov 13, 2026
Merged

cretz merged 1 commit into
mainfrom
cretz/remove-sandbox-show-secrets

Conversation

@cretz

@cretz cretz commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

🚀 What

  • Remove show_secrets from SandboxClient.get_info / AsyncSandboxClient.get_info; the backend no longer honors it
    • 💥 BACKWARDS INCOMPATIBLE CHANGE

💻 How

  • Drop the parameter and stop sending show_secrets
  • Remove the show_secrets reference from the SandboxEnvValue.secret doc
  • Leave the generated management client alone until the spec drops the param

🔬 Testing

  • Remove the secrets-revealed e2e test; the get_info e2e test already checks the masked values
  • Remove the show_secrets query-param unit test

@cretz
cretz requested review from cploujoux and a balanced review from Copilot November 13, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the removal of the unsupported show_secrets option.

No open issues 🎉

What changed in this PR

Removes the unsupported show_secrets option from the sandbox SDK’s synchronous and asynchronous get_info methods. This is a breaking API change; the generated management client remains unchanged pending a spec update.

Changes:

  • Remove the parameter and stop forwarding it to the management API.
  • Update environment-value documentation to state that secrets are masked.
  • Remove tests for revealing secrets and forwarding the removed parameter.
File Description
tests/​sandbox/​test_e2e.py Remove the secrets-revealed end-to-end test.
tests/​sandbox/​test_client.py Remove the show_secrets query-parameter test.
baseten/​sandbox/​_info.py Remove the documented exception to secret masking.
baseten/​sandbox/​_client.py Remove show_secrets from both get_info implementations.

Review effort: Balanced

@cretz
cretz merged commit 9d2c3dd into main Nov 13, 2026
12 of 14 checks passed
@cretz
cretz deleted the cretz/remove-sandbox-show-secrets branch November 13, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants