Repository navigation
Remove sandbox show_secrets option - #45
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of the unsupported show_secrets option.
No open issues 🎉
What changed in this PR
Removes the unsupported show_secrets option from the sandbox SDK’s synchronous and asynchronous get_info methods. This is a breaking API change; the generated management client remains unchanged pending a spec update.
Changes:
- Remove the parameter and stop forwarding it to the management API.
- Update environment-value documentation to state that secrets are masked.
- Remove tests for revealing secrets and forwarding the removed parameter.
| File | Description |
|---|---|
| tests/sandbox/test_e2e.py | Remove the secrets-revealed end-to-end test. |
| tests/sandbox/test_client.py | Remove the show_secrets query-parameter test. |
| baseten/sandbox/_info.py | Remove the documented exception to secret masking. |
| baseten/sandbox/_client.py | Remove show_secrets from both get_info implementations. |
Review effort: Balanced
wfortin
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
show_secretsfromSandboxClient.get_info/AsyncSandboxClient.get_info; the backend no longer honors it💻 How
show_secretsshow_secretsreference from theSandboxEnvValue.secretdoc🔬 Testing
get_infoe2e test already checks the masked valuesshow_secretsquery-param unit test