chore: support 3.14t#615
Conversation
📝 WalkthroughWalkthroughThe package declares free-threading support, refines dependencies for newer Python versions, adds Python 3.14t CI coverage with NumPy/SciPy constraints, and sorts notebook test execution. ChangesPython compatibility updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @phi-friday, thanks for the contributions as usual! And apologies for the delay, feel free to ping me if things take too long. |
|
Sorry for the delay in confirming this due to recent work adjustments. I’ll follow up shortly. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/run_tests.yml:
- Line 39: The uv installation step passes the combined numpy and scipy
constraints as one argument, causing installation to fail. Update the workflow
command to provide each requirement as a separate argument, or change the matrix
structure to store and expand the constraints independently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4675cc0e-de7b-41c8-b82d-dc549c6aaa0a
📒 Files selected for processing (1)
.github/workflows/run_tests.yml
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/run_tests.yml (1)
31-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider upgrading
actions/checkoutto v4.
actions/checkout@v3is deprecated and uses Node 16 which is no longer supported by GitHub Actions. Upgrading toactions/checkout@v4is a low-risk change that avoids future runner deprecation warnings.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/run_tests.yml at line 31, Update the checkout step in the workflow from actions/checkout@v3 to actions/checkout@v4 to use the supported Node runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/run_tests.yml:
- Line 31: Update the checkout step in the workflow from actions/checkout@v3 to
actions/checkout@v4 to use the supported Node runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b67661ec-2bdc-40ea-b1d7-8211a52a727d
📒 Files selected for processing (1)
.github/workflows/run_tests.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 10 10
Lines 1220 1220
=======================================
Hits 1200 1200
Misses 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds Python 3.14t support and updates compatibility checks for the free-threaded build.
Summary by CodeRabbit
Compatibility
Tests
Maintenance