Skip to content

chore: support 3.14t#615

Open
phi-friday wants to merge 10 commits into
bayesian-optimization:masterfrom
phi-friday:support-314t
Open

chore: support 3.14t#615
phi-friday wants to merge 10 commits into
bayesian-optimization:masterfrom
phi-friday:support-314t

Conversation

@phi-friday

@phi-friday phi-friday commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Adds Python 3.14t support and updates compatibility checks for the free-threaded build.

Summary by CodeRabbit

  • Compatibility

    • Added a Python “Free Threading” classifier for Python 3.14 free-threaded builds.
    • Refined dependency requirements with more precise Python-version markers and updated minimum versions for newer Python.
  • Tests

    • Made notebook execution order deterministic for more consistent test runs.
  • Maintenance

    • Updated the automated test workflow matrix to cover additional Python and NumPy/SciPy constraint combinations, including conditional dependency installation logic.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The package declares free-threading support, refines dependencies for newer Python versions, adds Python 3.14t CI coverage with NumPy/SciPy constraints, and sorts notebook test execution.

Changes

Python compatibility updates

Layer / File(s) Summary
Runtime metadata and dependency markers
pyproject.toml
Adds the Python free-threading classifier and partitions dependency requirements for Python 3.13+ and 3.14+.
CI interpreter matrix
.github/workflows/run_tests.yml
Adds Python 3.14t coverage, separates NumPy major versions, excludes incompatible combinations, and installs matching NumPy/SciPy constraints.
Deterministic notebook execution
tests/test_notebooks_run.py
Sorts discovered notebooks before parametrized execution.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: till-m

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Python 3.14t support and related free-threaded compatibility updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@t-muser

t-muser commented Jun 17, 2026

Copy link
Copy Markdown
Member

Hey @phi-friday, thanks for the contributions as usual! And apologies for the delay, feel free to ping me if things take too long.

@phi-friday

Copy link
Copy Markdown
Contributor Author

Sorry for the delay in confirming this due to recent work adjustments. I’ll follow up shortly.

@phi-friday phi-friday marked this pull request as ready for review July 10, 2026 14:14
@phi-friday phi-friday changed the title [WIP] chore: support 3.14t chore: support 3.14t Jul 10, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/run_tests.yml:
- Line 39: The uv installation step passes the combined numpy and scipy
constraints as one argument, causing installation to fail. Update the workflow
command to provide each requirement as a separate argument, or change the matrix
structure to store and expand the constraints independently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4675cc0e-de7b-41c8-b82d-dc549c6aaa0a

📥 Commits

Reviewing files that changed from the base of the PR and between 47b89ee and 9a4929b.

📒 Files selected for processing (1)
  • .github/workflows/run_tests.yml

Comment thread .github/workflows/run_tests.yml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/run_tests.yml (1)

31-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider upgrading actions/checkout to v4.

actions/checkout@v3 is deprecated and uses Node 16 which is no longer supported by GitHub Actions. Upgrading to actions/checkout@v4 is a low-risk change that avoids future runner deprecation warnings.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/run_tests.yml at line 31, Update the checkout step in the
workflow from actions/checkout@v3 to actions/checkout@v4 to use the supported
Node runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/run_tests.yml:
- Line 31: Update the checkout step in the workflow from actions/checkout@v3 to
actions/checkout@v4 to use the supported Node runtime.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b67661ec-2bdc-40ea-b1d7-8211a52a727d

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba1475 and 657d6ee.

📒 Files selected for processing (1)
  • .github/workflows/run_tests.yml

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.36%. Comparing base (72f93ac) to head (657d6ee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          10       10           
  Lines        1220     1220           
=======================================
  Hits         1200     1200           
  Misses         20       20           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants