Skip to content

fix(dispute): hide View Transaction when no txid exists - #416

Merged
nghiacc merged 1 commit into
masterfrom
cursor/hide-null-dispute-tx-3c11
Sep 23, 2026
Merged

nghiacc merged 1 commit into
masterfrom
cursor/hide-null-dispute-tx-3c11

Conversation

@nghiacc

@nghiacc nghiacc commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

What

On a resolved dispute, View Transaction always linked to releaseTxid or returnTxid. Returning funds only stores the arbitrator signature first. The seller still has to claim, so both ids are empty and the link was https://explorer.e.cash/tx/null.

View Transaction now renders only when one of those ids is present. A release id is still preferred over a return id.

Test

next build typechecked and generated the dispute-detail page. The live resolved dispute was not opened in a browser; that screen needs the production session.

Open in Web Open in Cursor 

Resolving a dispute stores the return signature before anyone broadcasts
a transaction. The resolved screen was still linking to /tx/null.
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 761c5604-4dad-4419-b453-556fdfe8ac37

📥 Commits

Reviewing files that changed from the base of the PR and between f3d17cc and 95a2a27.

📒 Files selected for processing (1)
  • apps/telegram-ecash-escrow/src/app/dispute-detail/page.tsx
 ____________________________________________________________________________________________________________________
< Always design for concurrency. Allow for concurrency, and you'll design cleaner interfaces with fewer assumptions. >
 --------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nghiacc
nghiacc marked this pull request as ready for review September 23, 2026 21:24
@nghiacc
nghiacc merged commit 9cdee8c into master Sep 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants