Repository navigation
fix(dispute): hide View Transaction when no txid exists - #416
Merged
Merged
Conversation
Resolving a dispute stores the return signature before anyone broadcasts a transaction. The resolved screen was still linking to /tx/null.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nghiacc
marked this pull request as ready for review
September 23, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a resolved dispute, View Transaction always linked to
releaseTxidorreturnTxid. Returning funds only stores the arbitrator signature first. The seller still has to claim, so both ids are empty and the link washttps://explorer.e.cash/tx/null.View Transaction now renders only when one of those ids is present. A release id is still preferred over a return id.
Test
next buildtypechecked and generated the dispute-detail page. The live resolved dispute was not opened in a browser; that screen needs the production session.