Skip to content

Add metadata lookup in parent DataTree attrs to core rules#73

Open
clarasb wants to merge 4 commits into
mainfrom
clara/63-datatree_global_attrs
Open

Add metadata lookup in parent DataTree attrs to core rules#73
clarasb wants to merge 4 commits into
mainfrom
clara/63-datatree_global_attrs

Conversation

@clarasb

@clarasb clarasb commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

This PR adds metadata lookup in parent DataTree attrs to core rules.

Some metadata rules check “global” attrs, but these attrs can live in a parent/root group while the data lives in a child group. The changes in this PR let the rule content-desc and conventions, look up attrs from parent DataTree groups without copying them into child datasets. Local attrs still take precedence, so the physical group structure stays unchanged.

Closes #63.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (57fb020) to head (67492c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   99.48%   99.49%           
=======================================
  Files          74       75    +1     
  Lines        2935     2967   +32     
  Branches      426      432    +6     
=======================================
+ Hits         2920     2952   +32     
  Partials       15       15           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clarasb
clarasb marked this pull request as ready for review July 21, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attributes from parent group not recognized

1 participant