Skip to content

Make return properties on basic vocab functions configurable - #122

Merged
elewis2 merged 3 commits into
developfrom
feature/configurable-return-props
Oct 2, 2026
Merged

elewis2 merged 3 commits into
developfrom
feature/configurable-return-props

Conversation

@creisle

@creisle creisle commented Sep 21, 2026

Copy link
Copy Markdown
Member

Makes return_properties configurable. This means if you want "all" you can set it to None or otherwise specify the properties you want. this does not change the default behaviour

I also only return @Rid for the query where we convert it to @Rid later anyway just to avoid loading more data than we need

@creisle
creisle requested a review from elewis2 September 21, 2026 23:36
@codecov-commenter

codecov-commenter commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.86%. Comparing base (c737abb) to head (5c24487).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #122   +/-   ##
========================================
  Coverage    87.85%   87.86%           
========================================
  Files           18       18           
  Lines         2635     2636    +1     
========================================
+ Hits          2315     2316    +1     
  Misses         320      320           
Flag Coverage Δ
unittests 87.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elewis2
elewis2 merged commit 55ff321 into develop Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants