Repository navigation
Feat/add caching tests - #124
Merged
Merged
Conversation
elewis2
commented
Sep 29, 2026
Collaborator
- adds tests for caching and rate limiting
- removes [sqlite] from requests-cache requirement and fixes version at 1.3.3, to avoid zc.buildout error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #124 +/- ##
===========================================
+ Coverage 87.81% 88.04% +0.22%
===========================================
Files 18 18
Lines 2635 2635
===========================================
+ Hits 2314 2320 +6
+ Misses 321 315 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
elewis2
requested review from
bnguyen-bcgsc and
dustinbleile
and
a lite review from Copilot
October 1, 2026 18:28
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds GraphKB caching and rate-limiting tests, and pins requests-cache to version 1.3.3.
Changes:
- Adds cache filtering and cache behavior tests.
- Adds rate-limiting configuration tests.
- Removes the SQLite extra from
requests-cache.
| File | Description |
|---|---|
tests/test_graphkb/test_util.py |
Adds caching and rate-limiting tests. |
setup.cfg |
Pins requests-cache to version 1.3.3. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dustinbleile
reviewed
Oct 1, 2026
dustinbleile
previously approved these changes
Oct 1, 2026
bnguyen-bcgsc
previously approved these changes
Oct 1, 2026
elewis2
dismissed stale reviews from bnguyen-bcgsc and dustinbleile
via
October 1, 2026 21:08
cb69cd6
dustinbleile
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.