Skip to content

Feat/add caching tests - #124

Merged
elewis2 merged 3 commits into
developfrom
feat/add-caching-tests
Oct 2, 2026
Merged

elewis2 merged 3 commits into
developfrom
feat/add-caching-tests

Conversation

@elewis2

@elewis2 elewis2 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator
  • adds tests for caching and rate limiting
  • removes [sqlite] from requests-cache requirement and fixes version at 1.3.3, to avoid zc.buildout error

@elewis2
elewis2 requested a review from creisle September 29, 2026 21:48
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.04%. Comparing base (1353ca1) to head (cb69cd6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
+ Coverage    87.81%   88.04%   +0.22%     
===========================================
  Files           18       18              
  Lines         2635     2635              
===========================================
+ Hits          2314     2320       +6     
+ Misses         321      315       -6     
Flag Coverage Δ
unittests 88.04% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Adds GraphKB caching and rate-limiting tests, and pins requests-cache to version 1.3.3.

Changes:

  • Adds cache filtering and cache behavior tests.
  • Adds rate-limiting configuration tests.
  • Removes the SQLite extra from requests-cache.
File Description
tests/​test_graphkb/​test_util.py Adds caching and rate-limiting tests.
setup.cfg Pins requests-cache to version 1.3.3.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread setup.cfg Outdated
dustinbleile
dustinbleile previously approved these changes Oct 1, 2026
bnguyen-bcgsc
bnguyen-bcgsc previously approved these changes Oct 1, 2026
@elewis2
elewis2 dismissed stale reviews from bnguyen-bcgsc and dustinbleile via cb69cd6 October 1, 2026 21:08
@elewis2
elewis2 merged commit c737abb into develop Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants