Repository navigation
Conversation
…iiv columns Feature: newsletter-publishing/block-conversion/structured-content-blocks Implements: - US-006: A Columns block in a post becomes one beehiiv columns block Verified: - AC-008, AC-011 to AC-019 covered by PHPUnit tests - Up to 3 columns per block; more columns, or columns nested in a column, put their inner blocks at the top level - px/em/rem widths become a share of the row; percent widths round per column
Covers structured-content-blocks (AC-001 to AC-019) and block-conversion-framework (AC-001 to AC-008). Two specs assert known gaps and currently fail: table background color (AC-010) and a non-breaking-space paragraph (AC-005).
A table with a block background color sent no color. The color is now read from the block attributes, the table tag, or the figure wrapper, and sent as visual settings the same way lists and paragraphs send it.
…king space A paragraph with only a non-breaking space was still sent as a text block. The check now treats non-breaking spaces as blank.
…id image The PRD says a Media & Text block with no valid image URL is omitted. The converter kept the text column instead. The whole block is now omitted.
…iv sidebar is open The marker adds a class and tooltip to the block's own element instead of wrapping the block, shows only while the beehiiv sidebar is open, keeps the hidden-eye icon visible, and also covers posts linked to a scheduled newsletter.
…ollows the send warning text
…umns and mark them in the editor A Columns block with more than 3 columns was sent as top-level blocks. It is now omitted from the newsletter, and the editor marks it and counts it in the omitted blocks notice, the same as other blocks the newsletter leaves out. The column limit is shared with the editor through the block support config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A WordPress Columns block at the top level of a post now converts to one beehiiv
columnsblock. Before, Columns was skipped and its content was lost. Media & Text already used the same conversion.Teamwork task: https://fueled.teamwork.com/app/tasks/19814725
Closes #167
How it converts
core/columnbecomes one column. Its inner blocks go underblocks, in order.verticalAlign.stackOnMobileis true by default, as for Media & Text, and false only when the WordPress block opts out.core/columnsis now a supported block andcore/columnis nested-only, so the editor no longer lists them as omitted.Known difference
A ticket comment (2026-10-21) asked for an error message when a row has more than 3 columns. This PR follows the intake instead: the content is sent as top-level blocks and the editor shows no omitted-block warning.
Also fixed (found by the independent QA run, separate commits)
eb847c0).711d803).238514a).Tests
caa9ecd.lint:js,lint:cssandlint:phppass on PHP 7.4 to 8.5.Open questions