Repository navigation
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
data-slot | ba11b0b | Commit Preview URL Branch Preview URL |
Nov 10 2026, 10:09 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The only workflow is
.github/workflows/publish.yml, which runs onv*tags. Nothing runs on pull requests or on pushes tomain: tests only run at release time,bun run typechecknever runs in CI, and contributors' PRs are merged without automated checks.Fix
Add
.github/workflows/ci.yml, triggered onpull_requestand onpushtomain:permissions: contents: read; a concurrency group per workflow and ref that cancels superseded runs on pull requests (pushes tomainare not cancelled).ubuntu-latestjob (15 minute timeout) using the same toolchain aspublish.yml:actions/checkout@v4,oven-sh/setup-bun@v2pinned to bun1.4.3(the version the lockfile was produced with) instead oflatest, andactions/setup-node@v4with Node 22.bun install --frozen-lockfile,bun run build,bun run typecheck,bun test,bun run test:ui:published.tscresolves several@data-slot/*packages through their builtdist/*.d.ts(the roottsconfig.jsonpathsdoes not map them). A comment in the workflow says so.Left out deliberately: the website/Astro steps from
publish.yml(npm ci --prefix websiteand the Astro tree-shaking check). They are slow and belong to the release path.No changes to
publish.yml, package manifests, tsconfig, or source code.Checks
Run locally from a fresh
bun install --frozen-lockfilein a clean checkout of this branch (bun 1.4.3):bun install --frozen-lockfile: passes, lockfile unchangedbun run build: passes, UI build verified exports for 22 componentsbun run typecheck: passesbun test: 1828 pass, 0 fail across 52 filesbun run test:ui:published: verified ESM, CommonJS, and declarations for 22 UI componentsOpen in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.