feat: add recommended_trades to TrainingTrial and SimulationRunner integration - #42
Merged
Merged
Conversation
…tegration - Add recommended_trades: list[dict]|None to TrainingTrial dataclass - Update _trainer closure to derive recommended_trades from allocation_history - Verify _trainer computes sharpe_ratio, outperformance, model_roi, buyhold_roi - Update WorkflowRunner._run_trial() to extract recommended_trades from result - Update print_results() in alloc/cli.py to render trade recommendations - Add 21 tests for metric computation and recommended_trades - All 411 tests pass, ruff clean, mypy clean
belarusian
force-pushed
the
build13/simulation-integration
branch
from
August 14, 2026 04:20
874fe7b to
3bde6cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
recommended_trades: list[dict]|Noneto TrainingTrial dataclass_trainerclosure to derive recommended_trades from allocation_history_trainercomputes sharpe_ratio, outperformance, model_roi, buyhold_roiWorkflowRunner._run_trial()to extract recommended_trades from resultprint_results()in alloc/cli.py to render trade recommendationsVerification