Repository navigation
go.mod: caliper v1.7.0, the release with KeepWhenAllFail (#53) - #54
Merged
Merged
Conversation
Collaborator
Author
|
CI on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
What changes
alidade now depends on a released caliper. Since PR #44,
go.modhad pinned caliper to an unreleased commit (c88a51b, theKeepWhenAllFailchange for #41) as a pseudo-version. It now requires caliper v1.7.0, which you authorized me to release:v1.7.0on 7a1a643;v1.7.0's code is the pinned commit's plus a two-line changelog edit, so alidade builds the same caliper code as before.
Evidence
go.modandgo.sum: only caliper's lines change, from the pseudo-version to v1.7.0.go mod tidyis clean.THIRD_PARTY_NOTICES.txt: regenerated withGOROOT=~/projects/src/github.com/trendvidia/go go run scripts/notices.go. Only caliper's version line changed.-checkexits 0.go test -count=1 -tags v8,python ./...withCGO_ENABLEDunset: 20 packages ok, exit 0.golangci-lint run ./...: 0 issues.caliper's release workflow, which attaches the binaries, was still running when I opened this. alidade doesn't depend on those binaries.